store-gateway: fix stats recording in filtering...Iterator #4830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is panicking because stats is nil. I am planning to backport this to r235 Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
colega
approved these changes
Apr 25, 2023
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-4830-to-r235 origin/r235
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 29a3fcc2acb98a6266f87dfc35f7f78ce69263bd
# Push it to GitHub
git push --set-upstream origin backport-4830-to-r235
git switch main
# Remove the local backport branch
git branch -D backport-4830-to-r235Then, create a pull request where the |
dimitarvdimitrov
added a commit
that referenced
this pull request
Apr 25, 2023
--------- Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com> (cherry picked from commit 29a3fcc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This is a follow-up of #4797. This code is panicking because
statsarenil. I am planning to backport this to r235Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]