store-gateway: add series filtering metrics #4797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Around the work of issue 4593 we added the possibility to fetch series that don't necessarily match the request.
However, we aren't really measuring the proportion of series that are discarded because they don't match the request.
Ideally we'd want to measure the volume of data that is discarded, but this is more difficult. I believe that measuring
the number of series will be a good proxy for the volume of data too. This PR does that.
This PR adds the `stage` label on `cortex_bucket_store_series_data_touched{data_type="series"}` metrics. It can take
the value `returned` or `processed` (same as the `chunks` equivalent).
This PR also fixes a type in the mixin and clarifies the help texts of `cortex_bucket_store_series_result_series`.
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
dimitarvdimitrov
changed the title
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov@grafana.com>
colega
approved these changes
Apr 21, 2023
pracucci
approved these changes
Apr 21, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Around the work in #4593 we added the possibility to fetch series that don't necessarily match the request.
However, we aren't really measuring the proportion of series that are discarded because they don't match the request.
What this PR does
Ideally we'd want to measure the volume of data that is discarded, but this is more difficult. I believe that measuring
the number of series will be a good proxy for the volume of data too. This PR does that.
This PR adds the
stagelabel oncortex_bucket_store_series_data_touched{data_type="series"}metrics. It can takethe value
returnedorprocessed(same as thechunksequivalent).This PR also fixes a type in the mixin and clarifies the help texts of
cortex_bucket_store_series_result_series.Which issue(s) this PR fixes or relates to
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]