Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): Azure backend using thanos.io/objstore #11315

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

JoaoBraveCoding
Copy link
Collaborator

@JoaoBraveCoding JoaoBraveCoding commented Nov 24, 2023

What this PR does / why we need it*:

This PR adds support to use the thanos.io/objstore backend for the Azure provider for all components excluding the Ruler since it's similar to the work done in #11132.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

  • We tried to the best of our efforts to preserve feature parity so the new backend still uses the ObjectClient interface
  • Fix how some CLI variables we being passed (some HTTP CLI variables were under .http while others weren't)
  • Thanos.io/objstore doesn't support all the CLI flags Loki supports nowadays (see snippet below)
  • This PR was inspired by the way Mimir uses thanos.io/objstore with the goal of making this part of the codebase as similar as possible

CLI Table

azure.account-name
azure.account-key
azure.connection-string
azure.container-name
azure.endpoint-suffix
azure.user-assigned-id
azure.max-retries
azure.max-retry-delay

NOT SUPPORTED AT THE MOMENT
azure.environment
azure.use-managed-identity
azure.use-federated-token
azure.chunk-delimiter
azure.request-timeout
azure.download-buffer-size
azure.upload-buffer-size
azure.download-buffer-size
azure.min-retry-delay
azure.use-service-principal
azure.tenant-id
azure.client-id
azure.client-secret

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • CHANGELOG.md updated
    • If the change is worth mentioning in the release notes, add add-to-release-notes label
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

Copy link
Contributor

Trivy scan found the following vulnerabilities:

@JoaoBraveCoding JoaoBraveCoding changed the title storage: Azure backend using thanos.io/objstore feat(storage): Azure backend using thanos.io/objstore Mar 14, 2024
@github-actions github-actions bot added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Mar 15, 2024
@JoaoBraveCoding JoaoBraveCoding marked this pull request as ready for review March 18, 2024 15:59
@JoaoBraveCoding JoaoBraveCoding requested a review from a team as a code owner March 18, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant