-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): GCS backend using thanos.io/objstore #11132
base: main
Are you sure you want to change the base?
Conversation
a2f70a5
to
daf3d62
Compare
Signed-off-by: Joao Marcal <jmarcal@redhat.com>
daf3d62
to
0c88216
Compare
Trivy scan found the following vulnerabilities:
|
6b6b613
to
e816a3c
Compare
Thank you! ❤️ |
bc19a01
to
19f610c
Compare
dbc4d46
to
1043e28
Compare
1043e28
to
6728e2f
Compare
@JoaoBraveCoding thanks for the PR :) Update:
I will keep it posted here. Once those testing is done, we can approve and merge this PR |
@JoaoBraveCoding I was testing this PR and found it is breaking couple of our internal services.
Basically, looks like we cannot afford to change the signature of
|
Signed-off-by: Kaviraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
Signed-off-by: Kaviraj Kanagaraj <kavirajkanagaraj@gmail.com>
I'm planning to merge this PR. Let me know if anyone have any conflicts! There is one edge case when we enable The rationale for that is mainly if loki config have multiple period_configs, we create one object client per period_config and each will try to register the metrics collector in thanos currently. But in Loki currently we create those metrics once and make it part of transport so that all the object storage calls are tracked in single set of metrics. I have raised an upstream PR to decouple metrics creation and instrumenting the bucket. With this, we can create thanos metrics once and use it multiple instances of object clients. I have a changes ready to fix it in compactor, I will raise as separate PR (we can do similar things on other components as well) All these can be done iteratively, meaning we can merge this PR without keeping it open. Another important rationale is, this PR often get's outdated and needing some manual work. With RF=1 feature, people also touch object client API's so keeping this PR open going to make only worse with more frequent rebase & conflicts. Looping some people for visibility @JoaoBraveCoding @slim-bean |
540af4d
to
a3b367c
Compare
ec00fec
to
d51bbd5
Compare
d51bbd5
to
e4fd02d
Compare
What this PR does / why we need it:
This PR adds support to use the thanos.io/objstore backend for the GCS provider for all components including the Ruler.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
CLI Table
Checklist
CONTRIBUTING.md
guide (required)CHANGELOG.md
updatedadd-to-release-notes
labeldocs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR