[loki-distributed] Switch metric list order in HPAs #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveedyahyazadeh
force-pushed
the
loki-dist-hpa-order
branch
2 times, most recently
from
cea309c to
dc86589
Compare
|
@naveedyahyazadeh Could you solve the conflicts? The change itself looks good! |
Signed-off-by: Naveed Yahyazadeh <naveed.yahyazadeh@appian.com>
naveedyahyazadeh
force-pushed
the
loki-dist-hpa-order
branch
from
dc86589 to
73cb4ca
Compare
|
@torstenwalter Resolved! |
torstenwalter
approved these changes
Nov 8, 2021
|
Thank you very much! |
Merged
4 tasks
poblahblahblah
added a commit
to poblahblahblah/sumologic-kubernetes-collection
that referenced
this pull request
Jun 7, 2023
This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
poblahblahblah
added a commit
to poblahblahblah/sumologic-kubernetes-collection
that referenced
this pull request
Jun 12, 2023
This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
swiatekm
pushed a commit
to SumoLogic/sumologic-kubernetes-collection
that referenced
this pull request
Jun 13, 2023
* Reordering HPA metrics to match HPA ordering This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com> * add CHANGELOG entry --------- Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reorders the list in
spec.metricsfor all components' HPAs in order to circumvent issue kubernetes/kubernetes#74099. Without this change, GitOps style CD tools such as Argo will consider the HPAs permanently out of sync due to the following discrepancy: