[simple-app] Re-order HPA metrics #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diranged
reviewed
Jan 28, 2022
charts/simple-app/values.yaml
Outdated
| @@ -342,7 +342,7 @@ autoscaling: | |||
| # -- Configures the HPA to target a particular CPU utilization percentage | |||
| targetCPUUtilizationPercentage: 80 | |||
| # -- If supplied, configures the HPA to target a particular Memory utilization percentage | |||
| # targetMemoryUtilizationPercentage: 80 | |||
There was a problem hiding this comment.
Eh. I think it should be uncommented, but also left blank. You don't generally want to autoscale on CPU and Memory in most cases without lots of tuning. That's why it was left off here. It doesn't change the capability of the downstream chart from setting the value though.
There was a problem hiding this comment.
ooh yea that makes sense, i'll leave it as is
ericayin
force-pushed
the
simple-app-hpa-memory
branch
from
ae9af48 to
d25e2c1
Compare
ericayin
changed the title
diranged
reviewed
Jan 31, 2022
charts/simple-app/Chart.yaml
Outdated
| @@ -2,7 +2,7 @@ apiVersion: v2 | |||
| name: simple-app | |||
| description: Default Microservice Helm Chart | |||
| type: application | |||
| version: 0.16.2 | |||
| version: 0.16.3 | |||
There was a problem hiding this comment.
@ericayin oh rebase.. we're on 0.17+ now..
ericayin
force-pushed
the
simple-app-hpa-memory
branch
from
d25e2c1 to
5d609b6
Compare
Merged
4 tasks
poblahblahblah
added a commit
to poblahblahblah/sumologic-kubernetes-collection
that referenced
this pull request
Jun 7, 2023
This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
poblahblahblah
added a commit
to poblahblahblah/sumologic-kubernetes-collection
that referenced
this pull request
Jun 12, 2023
This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
swiatekm
pushed a commit
to SumoLogic/sumologic-kubernetes-collection
that referenced
this pull request
Jun 13, 2023
* Reordering HPA metrics to match HPA ordering This addresses an issue when using ArgoCD (and maybe other GitOps operators) where Kubernetes reorders the objects under the spec.metrics key thus causing Sync issues with ArgoCD. Originally reported to the ArgoCD project here: argoproj/argo-cd#1079 Originally reported to the Kubernetes project here: kubernetes/kubernetes#74099 Other projects and companies have also addressed this by simply reordering the metrics section: * kubernetes/ingress-nginx#10043 * nginx/kubernetes-ingress#3773 * grafana/helm-charts#758 * open-telemetry/opentelemetry-helm-charts#103 * Nextdoor/k8s-charts#102 Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com> * add CHANGELOG entry --------- Signed-off-by: Patrick O’Brien <patrick.obrien@thetradedesk.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes/kubernetes#74099