Update the gRPC dependency to v1.66.0 and deprecate RecvBufferPools
#580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
pstibrany
approved these changes
Aug 29, 2024
| @@ -41,7 +41,7 @@ jobs: | |||
| matrix: | |||
| # We want to make sure dskit can support multiple golang versions | |||
| # by ensuring the test would pass using all these supported versions. | |||
| go-version: ['1.21.x', '1.22.x'] | |||
| go-version: ['1.21.x', '1.22.x', '1.23.x'] | |||
There was a problem hiding this comment.
Is this required? If not, I'd suggest separate PR for this.
There was a problem hiding this comment.
Somewhat required, Loki already uses Go 1.23. A separate PR would have been better, but I don't want to wait another 25 minutes for the CI to run 😅
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
It updates the
google.golang.org/grpcdependency to the latest stable v1.66.0 version. It also removes an experimentalRecvBufferPoolfeature that I previously added in #510 because that was deprecated in the same version and now results in a compilation error. The good news is that it got replaced (grpc/grpc-go#7356) with something even better that's turned on by default, so we no longer need that config at all.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]