Add gRPC server recv buffer pool option #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
na--
changed the title
2 tasks
slim-bean
reviewed
Mar 27, 2024
slim-bean
reviewed
Mar 27, 2024
Base automatically changed from
ned/add-option-to-disable-grpc-sever-stats-tracking
to
main
March 27, 2024 15:28
Co-authored-by: Ed Welch <edward.welch@grafana.com>
na--
force-pushed
the
ned/add-grpc-recv-buffer-pool-option
branch
from
1c89a95
to
64cd5f3
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR builds on top of #507 and adds a dedicated option for enabling gRPC
RecvBufferPool.That's an experimental gRPC feature, so I decided to add it in a separate PR, given that individual users of dskit can enable it locally by manually adding it to
Cfg.Server.GRPCOptions. However, #507 is necessary even for that, because it prevents anyone from using the feature due to this limitation:Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]