Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed support for ingester.statefulset_replicas #210

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

pracucci
Copy link
Collaborator

What this PR does:
The issue #209 make me realise the chunks storage with WAL enabled is using a pattern different than any other place in our jsonnet to configure the number of replicas. Instead of fixing #209 applying the config option to blocks storage too, I'm proposing to remove that config option at all, because it's looks like breaking our config consistency.

Which issue(s) this PR fixes:
Fixes #209

Checklist

  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci requested a review from codesome October 29, 2020 09:03
@pracucci pracucci requested a review from a team as a code owner October 29, 2020 09:03
@pracucci pracucci merged commit f5104b4 into master Nov 10, 2020
@pracucci pracucci deleted the honor-ingester-replicas-for-blocks-storage branch November 10, 2020 14:25
@bboreham
Copy link
Contributor

I tried adding the lines given in the changelog, but I get Unknown variable: statefulSet.
Could you give more context on how they should be used?

@pracucci
Copy link
Collaborator Author

I tried adding the lines given in the changelog, but I get Unknown variable: statefulSet.
Could you give more context on how they should be used?

@bboreham Yes, sure. Something like this:

local statefulSet = $.apps.v1.statefulSet,

ingester_statefulset+:
    statefulSet.mixin.spec.withReplicas(9),

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$._config.ingester.statefulset_replicas not honoured for blocks storage ingesters
3 participants