Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$._config.ingester.statefulset_replicas not honoured for blocks storage ingesters #209

Closed
eamonryan opened this issue Oct 28, 2020 · 0 comments · Fixed by #210
Closed

$._config.ingester.statefulset_replicas not honoured for blocks storage ingesters #209

eamonryan opened this issue Oct 28, 2020 · 0 comments · Fixed by #210

Comments

@eamonryan
Copy link
Member

In https://github.com/grafana/cortex-jsonnet/blob/master/cortex/ingester.libsonnet#L92-L94 we can see:

statefulSet.new('ingester', $._config.ingester.statefulset_replicas

So, the number of replicas comes from the config file value.

However, in https://github.com/grafana/cortex-jsonnet/blob/master/cortex/tsdb.libsonnet#L87-L88 we can see

newIngesterStatefulSet(name, container)::
    statefulSet.new(name, 3, [

So if using tsdb.libsonnet you get ingesters hardcoded to 3, which seems odd.

cc @pracucci as filing this per his request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant