Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read AzureSettings from Grafana host via SDK #378

Merged
merged 1 commit into from
May 18, 2022
Merged

Read AzureSettings from Grafana host via SDK #378

merged 1 commit into from
May 18, 2022

Conversation

kostrse
Copy link
Contributor

@kostrse kostrse commented May 13, 2022

Use Grafana Azure SDK (github.com/grafana/grafana-azure-sdk-go/azsettings/env.go) to read azsettings.AzureSettings from environment variables passed by the Grafana host.

Fixes #357

@kostrse kostrse requested a review from a team as a code owner May 13, 2022 02:51
@kostrse kostrse requested review from asimpson and andresmgot and removed request for a team May 13, 2022 02:51
@kostrse
Copy link
Contributor Author

kostrse commented May 13, 2022

cc @sunker

kevinwcyu
kevinwcyu approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@kevinwcyu kevinwcyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I'll let @sunker have a look too.

sunker
sunker approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@sunker sunker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @kostrse!

@sunker sunker merged commit e25f75a into grafana:main May 18, 2022
@kostrse kostrse deleted the sdk-azure-settings branch May 18, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinwcyu kevinwcyu kevinwcyu approved these changes

@sunker sunker sunker approved these changes

@asimpson asimpson Awaiting requested review from asimpson asimpson was automatically assigned from grafana/aws-datasources

@andresmgot andresmgot Awaiting requested review from andresmgot andresmgot was automatically assigned from grafana/aws-datasources

Assignees
No one assigned
Labels
type/chore
Projects
AWS Datasources
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Azure settings should be received from the Grafana host
3 participants
@kostrse @sunker @kevinwcyu