Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure settings should be received from the Grafana host #357

Closed
Tracked by #366
kostrse opened this issue Apr 13, 2022 · 3 comments · Fixed by #378
Closed
Tracked by #366

Azure settings should be received from the Grafana host #357

kostrse opened this issue Apr 13, 2022 · 3 comments · Fixed by #378
Labels
datasource/ADX type/bug Something isn't working

Comments

@kostrse
Copy link
Contributor

kostrse commented Apr 13, 2022 •
edited
Loading

Currently Azure settings assume public cloud.
This is not critical for App Registration (client secret) authentication because user explicitly select a cloud, but it will be important for Managed Identity authentication because in that case the cloud should be the same as where Grafana hosted.

Related:
@kostrse kostrse added datasource/ADX type/bug Something isn't working labels Apr 13, 2022
@grafanabot grafanabot moved this to Incoming in AWS Datasources Apr 13, 2022
@fridgepoet fridgepoet moved this from Incoming to Backlog in AWS Datasources Apr 14, 2022
@kostrse kostrse mentioned this issue Apr 15, 2022
Closed
@sunker
Copy link
Contributor

sunker commented Apr 19, 2022

Just need to make sure this does not become a breaking change for those ones that are using app reg.

@kostrse kostrse mentioned this issue Apr 25, 2022
Closed
10 tasks
@kostrse
Copy link
Contributor Author

kostrse commented Apr 25, 2022

Just need to make sure this does not become a breaking change for those ones that are using app reg.

It should not be because azsettings.AzureSettings used only for Managed Identity which is not supported now.

@kostrse
Copy link
Contributor Author

kostrse commented Apr 25, 2022

Task for a common Azure settings reader implementation in Grafana Azure SDK:

This was referenced May 13, 2022
Merged
Merged
Repository owner moved this from Backlog to Done in AWS Datasources May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
datasource/ADX type/bug Something isn't working
Projects
AWS Datasources
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Read AzureSettings from Grafana host via SDK kostrse/azure-data-explorer-datasource
2 participants
@kostrse @sunker