Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE file is included in all assembled JAR files #64

Merged
merged 3 commits into from
Sep 9, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions develocity-gradle-plugin-adapters/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,9 @@ develocityAdaptersPublication {
name = "Develocity Gradle API adapters for Develocity and Gradle Enterprise Gradle plugins"
description = "Adapter interfaces for interacting with the Develocity and Gradle Enterprise Gradle plugins"
}

tasks.withType<Jar>().configureEach {
erichaagdev marked this conversation as resolved.
Show resolved Hide resolved
into(".") {
from(rootProject.layout.projectDirectory.file("../LICENSE"))
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐 New line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

6 changes: 6 additions & 0 deletions develocity-maven-extension-adapters/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,9 @@ develocityAdaptersPublication {
name = "Develocity API adapters for Develocity and Gradle Enterprise Maven extensions"
description = "Adapter interfaces for interacting with the Develocity and Gradle Enterprise Maven extension APIs"
}

tasks.withType<Jar>().configureEach {
from(file("../LICENSE")) {
into("META-INF")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ I saw Eric mentioning that the LICENSE file should be in the root of the JAR. But here it is not. Does it apply only to our Gradle deliverables?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it applies to all, this was just missed...fixed it

}
}