Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE file is included in all assembled JAR files #64

Merged
merged 3 commits into from
Sep 9, 2024

Conversation

welandaz
Copy link
Member

@welandaz welandaz commented Sep 6, 2024

No description provided.

@welandaz welandaz self-assigned this Sep 6, 2024
into(".") {
from(rootProject.layout.projectDirectory.file("../LICENSE"))
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧐 New line

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


tasks.withType<Jar>().configureEach {
from(file("../LICENSE")) {
into("META-INF")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ I saw Eric mentioning that the LICENSE file should be in the root of the JAR. But here it is not. Does it apply only to our Gradle deliverables?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it applies to all, this was just missed...fixed it

@welandaz welandaz merged commit e11c93e into main Sep 9, 2024
4 checks passed
@welandaz welandaz deleted the welandaz/include-license-in-jars branch September 9, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants