Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign in GraalVM website style #674

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Conversation

Y-Shcheholskyy
Copy link
Contributor

@Y-Shcheholskyy Y-Shcheholskyy commented Jan 13, 2025

Changed the appearance of the pages - background color, fonts, table of contents, snippets etc.
Added header and footer design

screencapture-file-Users-eugeneshcheholsky-native-build-tools-website-native-build-tools-docs-build-docs-asciidoc-index-html-2025-01-07-15_28_22
Знімок екрана 2025-01-08 о 14 51 19
Знімок екрана 2025-01-08 о 14 53 21

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 13, 2025
Copy link
Collaborator

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seem to be a mix of changes of style and guide. I think separating the 2 would make it easier to review.

Does this support a "light" theme too? I find dark themes pretty hard to read.

@Y-Shcheholskyy
Copy link
Contributor Author

There seem to be a mix of changes of style and guide. I think separating the 2 would make it easier to review.

Does this support a "light" theme too? I find dark themes pretty hard to read.

Yes, I agree, it is accidental. for some reason when I created this PR, the changes made in the previous got into it. Strangely. I created my branch from master, I don't know how it happened

There is no light theme, but I will try to make a light background with dark text for the guides and documentation

@Y-Shcheholskyy
Copy link
Contributor Author

Text changes were reverted. Please review.
The light theme enhancement can be done in a follow up PR.

@olyagpl olyagpl requested a review from dnestoro January 13, 2025 16:20
@Y-Shcheholskyy
Copy link
Contributor Author

Text changes in gradle and maven plugin files were reverted. Thanks for review

}

ul.sectlevel2 a {
font-size: 16px !important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we avoid using !important or it is necessary? (this comment applies to other !important statements as well)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not, cause I don't have access to bunch of files in docs/SRC/docs/asciidoc/css while working. Instead, these files are present in the docs/BUILD/docs/asciidoc/css when the site is generated. If I could edit them in the "SRC" folder, then of course I wouldn't use these modifiers because it's not good practice.

@dnestoro
Copy link
Collaborator

@Y-Shcheholskyy from the screenshots you shared, and based on the code I see, the PR looks good. Can you please share a screenshot how code snippets look like now (for example some build.gradle or pom.xml code snippets that we have in docs)?

@Y-Shcheholskyy
Copy link
Contributor Author

@Y-Shcheholskyy from the screenshots you shared, and based on the code I see, the PR looks good. Can you please share a screenshot how code snippets look like now (for example some build.gradle or pom.xml code snippets that we have in docs)?

Sure, here you are:
Frame 2514

@dnestoro dnestoro merged commit 0d77824 into graalvm:master Jan 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants