-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign in GraalVM website style #674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seem to be a mix of changes of style and guide. I think separating the 2 would make it easier to review.
Does this support a "light" theme too? I find dark themes pretty hard to read.
Yes, I agree, it is accidental. for some reason when I created this PR, the changes made in the previous got into it. Strangely. I created my branch from master, I don't know how it happened There is no light theme, but I will try to make a light background with dark text for the guides and documentation |
Text changes were reverted. Please review. |
Text changes in gradle and maven plugin files were reverted. Thanks for review |
} | ||
|
||
ul.sectlevel2 a { | ||
font-size: 16px !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we avoid using !important
or it is necessary? (this comment applies to other !important
statements as well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately not, cause I don't have access to bunch of files in docs/SRC/docs/asciidoc/css while working. Instead, these files are present in the docs/BUILD/docs/asciidoc/css when the site is generated. If I could edit them in the "SRC" folder, then of course I wouldn't use these modifiers because it's not good practice.
@Y-Shcheholskyy from the screenshots you shared, and based on the code I see, the PR looks good. Can you please share a screenshot how code snippets look like now (for example some build.gradle or pom.xml code snippets that we have in docs)? |
|
Changed the appearance of the pages - background color, fonts, table of contents, snippets etc.
Added header and footer design