Compat: refactor setBindGroup for 0 storage buffers in frag stage. #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrekshao
approved these changes
Dec 31, 2024
Most of these tests didn't seem to require storage buffers to test what they were testing so I switched them to uniform buffers. One of them used both storage and uniform buffers so I added more subcases so that it tests with both storage buffers and uniform buffers in compute stage only (this is for devices that don't support storage buffers in fragment stage). Then both compute+fragment stages like it was, but this case is skipped if there are no storage buffers in fragment shaders. I also added a case were it uses 2 uniform buffers. It's not clear what it's testing needs to buffers to be of different types.
greggman
force-pushed
the
setBindGroup
branch
from
f4cb6fc to
72f23e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these tests didn't seem to require storage buffers to test what they were testing so I switched them to uniform buffers.
One of them used both storage and uniform buffers so I added more subcases so that it tests with both storage buffers and uniform buffers in compute stage only (this is for devices that don't support storage buffers in fragment stage). Then both compute+fragment stages like it was, but this case is skipped if there are no storage buffers in fragment shaders. I also added a case were it uses 2 uniform buffers.
It's not clear what it's testing needs to buffers to be of different types.