Nodejs 7.2 async/await #733

gbahamondezc · 2016-12-03T02:53:30Z

I'm using NodeJS 7 + gulp-istanbul for my test coverage and i'm getting Unexpected identifier with a async method of a class.

    class SomeClass {
        async someMethod() {
            return await  somePromise();
        }
    }

Is this issue related direct with Istanbul?
If so, there's some way to support this case?

BrandonZacharie · 2017-01-12T06:19:38Z

I get a bunch or errors that look like

Transformation error; return original code
{ Error: Line 22: Unexpected token =>
    at constructError (node_modules/esprima/esprima.js:2407:21)
    at createError (node_modules/esprima/esprima.js:2426:17)
    at unexpectedTokenError (node_modules/esprima/esprima.js:2500:13)
    at throwUnexpectedToken (node_modules/esprima/esprima.js:2505:15)
    at consumeSemicolon (node_modules/esprima/esprima.js:2620:13)
    ...

Maybe esprima needs to be upgraded or patched.

sabakugaara · 2017-01-21T01:27:46Z

@gbahamondezc, istanbul shuold be ^1.0.0 and try this:

node --harmony ./node_modules/.bin/istanbul cover ./node_modules/.bin/_mocha -- tests/*

kevinludwig · 2017-02-08T17:53:06Z

@sabakugaara the most recent version of istanbul is 0.4.5; do you mean gulp-istanbul >= 1.0.0? Also as far as I can tell, the problem is that the parser being used is esprima, and it does not yet support async/await it only claims to support ES2016. So I think the answer here is that esprima needs to support ES2017 and then istanbul needs to be upgraded to a compliant version of esprima, and then gulp-istanbul needs to be bumped to take that new version of istanbul. If you'd like to verify for yourself that this is the case, you can look at the esprima online parser, just type in a simple do nothing async function and it will complain: http://esprima.org/demo/parse.html.

sabakugaara · 2017-02-09T04:53:52Z

@kevinludwig try this: istanbul 1.1-alpha

kevinludwig · 2017-02-09T06:01:05Z

npm ERR! No compatible version found: gulp-istanbul@1.1.0-alpha.1
npm ERR! Valid install targets:
npm ERR! 1.1.1, 1.1.0, 1.0.0, 0.10.4, 0.10.3, 0.10.2, 0.10.1, 0.10.0, 0.9.0, 0.8.1, 0.8.0, 0.7.0, 0.6.0, 0.5.0, 0.4.0, 0.3.1, 0.3.0, 0.2.2, 0.2.1, 0.2.0, 0.1.1, 0.1.0

sabakugaara · 2017-02-10T05:59:19Z

maybe gulp-istanbul should update dependencies https://github.com/SBoudrias/gulp-istanbul/blob/master/package.json#L32

kevinludwig · 2017-02-10T19:06:35Z

don't think that helps. Latest version of istanbul is 0.4.5 and the version specified by gulp-istanbul is ^0.4.0 so it will end up pulling down 0.4.5. The problem is that istanbul has a dependency on esprima and esprima doesn't yet seem to support async/await.

kevinludwig · 2017-02-10T19:21:35Z

for what its worth, I tried upgrading esprima to 4.0.0-dev (the istanbul dependency) which is currently whats on master in github (for esprima), and the problem persists.

kevinludwig · 2017-02-23T22:33:18Z

Welp, node 7.6 landed and async/await is no longer behind a harmony flag, but I still can't get coverage for async/await.

patrikx3 · 2017-02-24T07:51:15Z

yep, async/await is not working :( i think it is the last important language update for a while.

thetutlage · 2017-02-24T07:52:42Z

Install 1.1.0-alpha.1 from npm and it works. Just did a minute ago

npm i --save-dev istanbul@v1.1.0-alpha.1

patrikx3 · 2017-02-24T08:25:17Z

works! thanks!

magicdawn · 2017-02-26T04:05:30Z

use npm i istanbul@next --save-dev, not @latest

gbahamondezc · 2017-02-26T13:55:33Z

Works, perfect with alpha version.

kevinludwig · 2017-03-03T17:40:27Z

what would you recommend as the way to get gulp-istanbul working? I have this vague feeling that if I make a PR to that repo saying "just use the alpha version of istanbul" I will get rejected.

kevinludwig · 2017-03-03T17:44:42Z

also if I just do cd node_modules/gulp-istanbul && npm install istanbul@next, then run a npm test for my project, it blows up inside of gulp-istanbul code, this is the complaint:

    var instrumenter = new opts.instrumenter(fileOpts);
                       ^
TypeError: opts.instrumenter is not a constructor

So did the interface change for istanbul in a way that would break gulp-istanbul?

kevinludwig · 2017-03-03T17:46:05Z

It's trying to do new istanbul.Instrumenter(fileOpts) just to make that a bit more clear.

kevinludwig · 2017-03-14T05:26:43Z

@gotwarlost
So I've realized that the API has pretty drastically changed between 0.4.5 and 1.1.0-alpha.1, which is why gulp-istanbul is not a trivial version bump upgrade. I'd be willing to give it a shot changing gulp-istanbul to work with istanbul@next but the docs don't seem to be updated at last on the README for the 1.1.0-alpha.1 tag. What are the chances that the README will be updated any time soon to reflect the new API?

ovaar · 2017-03-21T09:09:06Z

Is there any improvements on this issue?

electerious · 2017-06-24T15:53:11Z

From the readme:

Deprecation Notice: this version of istanbul is deprecated, we will not be landing pull requests or releasing new versions. But don't worry, the Istanbul 2.0 API is now available and is being actively developed in the new istanbuljs organization.

async/await is supported by default in the new version: https://github.com/istanbuljs/istanbuljs

Took me a while to realize that there's a difference between istanbul and istanbuljs on npm.

Also * Use istanbul@next to parse async/await js files * gotwarlost/istanbul#733 * Make istanbul to report the whole coverage under lib directory

bforbis · 2017-12-10T05:40:08Z

A few questions:

Is istanbul v1.1.0-alpha.1 going to be released as a standard release? I understand that this package is considered deprecated in favor of what is available at https://istanbul.js.org using nyc, but it seems like upgrading to nyc is not necessarily trivial. To get async/await support using nyc, you have to involve babel. Now that async/await is part of the LTS release of node, I'd rather not involve babel into my project if I can avoid it.

kevinludwig · 2017-12-10T05:48:06Z

Nyc does not require banel with latest node. Its vastly simpler than the gulp plugin.

bforbis · 2017-12-10T17:22:21Z

Oh, looks like I misunderstood the istanbul website which wasn't clear on whether babel-plugin-istanbul was required. @kevinludwig is correct, this is not required.

bennycode · 2018-04-14T20:09:50Z

I also had problems using async and await calls in my jasmine tests. Updated istanbul from "0.4.5" to "1.1.0-alpha.1" and it works now like a charm! ✨

Here is my npm "coverage" script:

"coverage": "rimraf coverage && cross-env NODE_ENV=test istanbul cover --report html ./node_modules/jasmine/bin/jasmine.js"

This is an initial implementation of ShareDB's [`MilestoneDB`][1]. The base bones of `MongoMilestoneDB` are based on the [`sharedb-mongo`][2] database adapter. This adapter is a slight departure from other ShareDB code, as it is written in ES7 for easier maintenance, especially when dealing with asynchronous code, as this gives us access to the `async`/`await` notation (although we can't realise its full potential due to needing to deal with consumer callbacks to be consistent with the rest of ShareDB). The move to ES7 drops support for Node v6. This library notably uses v2 of [`mongodb`][3] instead of the newer v3. This is to stay consistent with `sharedb-mongo`, so in theory the same config (or style of config) can be used in both `sharedb-mongo` and in `sharedb-milestone-mongo`. The version of [`istanbul`][4] is also bumped to the alpha version to [support ES7 syntax][5]. We also move away from `jshint` and use `eslint` with some more aggressive linting. [1]: share/sharedb#236 [2]: https://github.com/share/sharedb-mongo [3]: https://mongodb.github.io/node-mongodb-native/ [4]: https://github.com/gotwarlost/istanbul [5]: gotwarlost/istanbul#733

BrandonZacharie mentioned this issue Jan 12, 2017

Document how to use --harmony* flags with _mocha mochajs/mocha#2665

Closed

gbahamondezc closed this as completed Feb 26, 2017

dead-horse mentioned this issue Mar 8, 2017

deps: upgrade istanbul to 1.1.0-alpha.1 eggjs/egg-bin#43

Merged

kevinludwig mentioned this issue Mar 14, 2017

does not work with async/await (node 7.6+) SBoudrias/gulp-istanbul#116

Closed

sukima mentioned this issue Apr 19, 2017

Parsing async/await crashes ember-cli-code-coverage/ember-cli-code-coverage#108

Closed

rondale-sc mentioned this issue May 17, 2017

[Fixes #111] Update dependencies, get babel instrumenter working ember-cli-code-coverage/ember-cli-code-coverage#115

Merged

1 task

jiangli373 mentioned this issue Jul 28, 2017

npm install istanbul v1.1.0-alpha.1 error #828

Open

neilbmclaughlin mentioned this issue Aug 1, 2017

Istanbul generates errors with async/await nhsuk/gp-finder#199

Closed

jcalfee pushed a commit to EOSIO/eosjs-keygen that referenced this issue Dec 20, 2017

Using istanbul alpha for async function support. gotwarlost/istanbul#733

44577fe

amotzte mentioned this issue Jan 17, 2018

Upgrade to istanbuljs gotwarlost/istanbul-middleware#54

Open

kierans mentioned this issue Feb 8, 2018

Async await support karma-runner/karma-coverage#321

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nodejs 7.2 async/await #733

Nodejs 7.2 async/await #733

gbahamondezc commented Dec 3, 2016

BrandonZacharie commented Jan 12, 2017

sabakugaara commented Jan 21, 2017

kevinludwig commented Feb 8, 2017

sabakugaara commented Feb 9, 2017

kevinludwig commented Feb 9, 2017

sabakugaara commented Feb 10, 2017

kevinludwig commented Feb 10, 2017 •

edited

Loading

kevinludwig commented Feb 10, 2017

kevinludwig commented Feb 23, 2017

patrikx3 commented Feb 24, 2017

thetutlage commented Feb 24, 2017 •

edited

Loading

patrikx3 commented Feb 24, 2017

magicdawn commented Feb 26, 2017 •

edited

Loading

gbahamondezc commented Feb 26, 2017

kevinludwig commented Mar 3, 2017

kevinludwig commented Mar 3, 2017

kevinludwig commented Mar 3, 2017

kevinludwig commented Mar 14, 2017

ovaar commented Mar 21, 2017

electerious commented Jun 24, 2017

bforbis commented Dec 10, 2017 •

edited

Loading

kevinludwig commented Dec 10, 2017

bforbis commented Dec 10, 2017

bennycode commented Apr 14, 2018

Nodejs 7.2 async/await #733

Nodejs 7.2 async/await #733

Comments

gbahamondezc commented Dec 3, 2016

BrandonZacharie commented Jan 12, 2017

sabakugaara commented Jan 21, 2017

kevinludwig commented Feb 8, 2017

sabakugaara commented Feb 9, 2017

kevinludwig commented Feb 9, 2017

sabakugaara commented Feb 10, 2017

kevinludwig commented Feb 10, 2017 • edited Loading

kevinludwig commented Feb 10, 2017

kevinludwig commented Feb 23, 2017

patrikx3 commented Feb 24, 2017

thetutlage commented Feb 24, 2017 • edited Loading

patrikx3 commented Feb 24, 2017

magicdawn commented Feb 26, 2017 • edited Loading

gbahamondezc commented Feb 26, 2017

kevinludwig commented Mar 3, 2017

kevinludwig commented Mar 3, 2017

kevinludwig commented Mar 3, 2017

kevinludwig commented Mar 14, 2017

ovaar commented Mar 21, 2017

electerious commented Jun 24, 2017

bforbis commented Dec 10, 2017 • edited Loading

kevinludwig commented Dec 10, 2017

bforbis commented Dec 10, 2017

bennycode commented Apr 14, 2018

kevinludwig commented Feb 10, 2017 •

edited

Loading

thetutlage commented Feb 24, 2017 •

edited

Loading

magicdawn commented Feb 26, 2017 •

edited

Loading

bforbis commented Dec 10, 2017 •

edited

Loading