Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: upgrade istanbul to 1.1.0-alpha.1 #43

Merged
merged 2 commits into from
Mar 9, 2017
Merged

deps: upgrade istanbul to 1.1.0-alpha.1 #43

merged 2 commits into from
Mar 9, 2017

Conversation

dead-horse
Copy link
Member

No description provided.

@mention-bot
Copy link

@dead-horse, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @atian25 and @popomore to be potential reviewers.

@dead-horse
Copy link
Member Author

有点奇怪,刚才跑 async 的测试抛了一个异常。

gotwarlost/istanbul#733

@fengmk2
Copy link
Member

fengmk2 commented Mar 8, 2017

ci 修复一下

@dead-horse
Copy link
Member Author

image

@dead-horse
Copy link
Member Author

跑了一下 egg 的,没有问题

@dead-horse
Copy link
Member Author

让 CI 再跑一下

@dead-horse
Copy link
Member Author

@fengmk2 @popomore 再看一下

@@ -48,7 +48,7 @@ describe('egg-bin cov', () => {
.expect('stdout', /✓ should success/)
.expect('stdout', /a\.test\.js/)
.expect('stdout', /b\/b\.test\.js/)
.expect('stdout', /Statements {3}: 100% \( 0\/0 \)/)
.expect('stdout', /Statements {3}: Unknown% \( 0\/0 \)/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为啥是 Unknown

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

覆盖行数是 0/0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看来这里改了

@popomore popomore merged commit 044669f into master Mar 9, 2017
@popomore popomore deleted the deps-istanbul branch March 9, 2017 09:50
@popomore
Copy link
Member

popomore commented Mar 9, 2017

  • egg-bin@2.4.0

popomore pushed a commit that referenced this pull request May 5, 2017
popomore added a commit that referenced this pull request Jun 15, 2017
popomore added a commit that referenced this pull request Jun 15, 2017
* Revert "deps: upgrade istanbul to 1.1.0-alpha.1 (#43) (#51)"

This reverts commit 3608eef.

* Revert "Release 1.11.0"

This reverts commit 11bc901.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants