Fix dead lock in SessionPool #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that in dashmap we were occasionally getting unlucky and having sessions sometimes end up in the same shard, which would cause a deadlock since one would be trying to insert into a shard while we still hold a reference to one. Fortunately this is a pretty simple fix of not returning a reference at all and instead just returning the socket, since that was the only thing that was used out of the session struct.
XAMPPRocky
force-pushed
the
ep/fix-deadlock
branch
from
d09709d to
2a4b520
Compare
koslib
approved these changes
Oct 18, 2023
|
Build Succeeded 🥳 Build Id: d8571138-b3ea-48b5-be1b-05a669a4c55b The following development images have been built, and will exist for the next 30 days: To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that in dashmap we were occasionally getting unlucky and having sessions sometimes end up in the same shard, which would cause a deadlock since one would be trying to insert into a shard while we still hold a reference to one.
Fortunately this is a pretty simple fix of not returning a reference at all and instead just returning the socket, since that was the only thing that was used out of the session struct.