-
Notifications
You must be signed in to change notification settings - Fork 98
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The problem was that in dashmap we were occasionally getting unlucky and having sessions sometimes end up in the same shard, which would cause a deadlock since one would be trying to insert into a shard while we still hold a reference to one. Fortunately this is a pretty simple fix of not returning a reference at all and instead just returning the socket, since that was the only thing that was used out of the session struct.
- Loading branch information
1 parent
cc2244b
commit 2a4b520
Showing
2 changed files
with
69 additions
and
67 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters