Consistent implementation of source/dest #468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes all the places we had to/from and made sure they are source/dest. Closes googleforgames#448
iffyio
approved these changes
Jan 13, 2022
XAMPPRocky
approved these changes
Jan 13, 2022
|
Build Succeeded 🥳 Build Id: 1b98b2f7-eaf1-4be3-9b19-976651702f56 To build this version: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / Why we need it:
Changes all the places we had to/from and made sure they are source/dest.
Which issue(s) this PR fixes:
Closes #448
Special notes for your reviewer:
I don't think this touches any public APIs, so I didn't mark it as
breaking- if you catch anything I missed, please let me know.