Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to source/destination rather than to/from #448

Closed
markmandel opened this issue Nov 29, 2021 · 0 comments · Fixed by #468
Closed

Refactor to source/destination rather than to/from #448

markmandel opened this issue Nov 29, 2021 · 0 comments · Fixed by #468
Labels
kind/cleanup Refactoring code, fixing up documentation, etc

Comments

@markmandel
Copy link
Contributor

We currently use both to/from nomenclature across the codebase, as well as source/destination -- and sometimes we even conflate the two, which is extra confusing.

Let's consolidate things to source and destination and be consistent across the code base.

my preference would be to use src/dest and we can go through the code base and update usages. but in any case neither change is related to this PR and we can leave this as is

Originally posted by @iffyio in #441 (comment)
@markmandel markmandel mentioned this issue Nov 29, 2021
Merged
markmandel added a commit to markmandel/quilkin that referenced this issue Jan 13, 2022
@markmandel
Consistent implementation of source/dest
f4bfca7 
Changes all the places we had to/from and made sure they are
source/dest.

Closes googleforgames#448
@markmandel markmandel mentioned this issue Jan 13, 2022
Merged
XAMPPRocky added a commit that referenced this issue Jan 13, 2022
@markmandel @XAMPPRocky
Consistent implementation of source/dest (#468)
b32e48a 
Changes all the places we had to/from and made sure they are
source/dest.

Closes #448

Co-authored-by: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consistent implementation of source/dest markmandel/quilkin
1 participant
@markmandel