Refactor Compress with on_read & on_write config #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iffyio
approved these changes
Feb 23, 2021
| /// Compress traffic flowing downstream (received by an endpoint, and sent to the proxy listening port) | ||
| #[serde(rename = "DOWNSTREAM")] | ||
| Downstream, | ||
| enum Action { |
There was a problem hiding this comment.
The operation label for the filter's metrics should likely now be updated to action to match? If so we should update that and the docs as well
There was a problem hiding this comment.
That's an excellent call. Will make that change here and make a note on the other PR too.
Includes update to proto configuration to match as well. Closes #196
markmandel
force-pushed
the
refactor/compress-read-write
branch
from
9a6534a to
b1e6b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes update to proto configuration to match as well.
Closes #196