Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Compress Filter with on_read & on_write configuration #196

Closed
markmandel opened this issue Feb 22, 2021 · 0 comments · Fixed by #197
Closed

Refactor Compress Filter with on_read & on_write configuration #196

markmandel opened this issue Feb 22, 2021 · 0 comments · Fixed by #197
Labels
kind/cleanup Refactoring code, fixing up documentation, etc

Comments

@markmandel
Copy link
Contributor

Context:
#188 (comment)

TL;DR:
Configuration should change from being a direction to being:

on_read=COMPRESS|DECOMPRESS|DO_NOTHING
on_write=COMPRESS|DECOMPRESS|DO_NOTHING

Which is far more flexible, aligns with Envoy naming, and is avoids much confusion.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 22, 2021
@markmandel markmandel mentioned this issue Feb 22, 2021
Merged
markmandel added a commit that referenced this issue Feb 22, 2021
@markmandel
Refactor Compress with on_read & on_write config
9a6534a 
Includes update to proto configuration to match as well.

Closes #196
@markmandel markmandel mentioned this issue Feb 22, 2021
Merged
markmandel added a commit that referenced this issue Feb 23, 2021
@markmandel
Refactor Compress with on_read & on_write config
b1e6b87 
Includes update to proto configuration to match as well.

Closes #196
markmandel added a commit that referenced this issue Feb 24, 2021
@markmandel
Refactor Compress with on_read & on_write config (#197)
2e47932 
Includes update to proto configuration to match as well.

Closes #196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor Compress with on_read & on_write config googleforgames/quilkin
1 participant
@markmandel