Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify gen-all-sdk-grpc has run #3349

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Verify gen-all-sdk-grpc has run #3349

merged 2 commits into from
Aug 25, 2023

Commits on Aug 25, 2023

  1. Move the restapi folder GRPC_PORT off of the same port as the go fold… 

    …er tests

This may be causing some sort of conflict in the tests in googleforgames#3310. Not
sure why only googleforgames#3310 is seeing it, but it's not hard to make this
consistent.
    @zmerlynn
    zmerlynn committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    959abbf View commit details
    Browse the repository at this point in the history

  2. Verify gen-all-sdk-grpc has run 

    Adds a build step to verify that `make gen-all-sdk-grpc` has run.

Credit to @Kalaiselvi84 for original googleforgames#3310

Sample output:
```
=== Diffing workspace after 'make gen-all-sdk-grpc'
*** Failure: Differences found:
D    sdks/rust/proto/allocation/allocation.proto
D    sdks/rust/proto/googleapis/google/api/annotations.proto
D    sdks/rust/proto/googleapis/google/api/client.proto
D    sdks/rust/proto/googleapis/google/api/field_behavior.proto
D    sdks/rust/proto/googleapis/google/api/http.proto
D    sdks/rust/proto/googleapis/google/api/launch_stage.proto
D    sdks/rust/proto/googleapis/google/api/resource.proto
D    sdks/rust/proto/grpc-gateway/LICENSE.txt
D    sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/annotations.proto
D    sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/openapiv2.proto
D    sdks/rust/proto/sdk/alpha/alpha.proto
D    sdks/rust/proto/sdk/beta/beta.proto
D    sdks/rust/proto/sdk/sdk.proto
```

(Note this sample output was also what happens when I just run this
check on my desktop because the `rust` generation spews files as root.)
    @zmerlynn
    zmerlynn committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    423ec21 View commit details
    Browse the repository at this point in the history