Verify gen-all-sdk-grpc has run #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gongmax
approved these changes
Aug 25, 2023
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gongmax, zmerlynn The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build Failed 😱 Build Id: 2d06ba52-8ff1-47de-91ee-1b932b0eaa27 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
…er tests This may be causing some sort of conflict in the tests in googleforgames#3310. Not sure why only googleforgames#3310 is seeing it, but it's not hard to make this consistent.
Adds a build step to verify that `make gen-all-sdk-grpc` has run. Credit to @Kalaiselvi84 for original googleforgames#3310 Sample output: ``` === Diffing workspace after 'make gen-all-sdk-grpc' *** Failure: Differences found: D sdks/rust/proto/allocation/allocation.proto D sdks/rust/proto/googleapis/google/api/annotations.proto D sdks/rust/proto/googleapis/google/api/client.proto D sdks/rust/proto/googleapis/google/api/field_behavior.proto D sdks/rust/proto/googleapis/google/api/http.proto D sdks/rust/proto/googleapis/google/api/launch_stage.proto D sdks/rust/proto/googleapis/google/api/resource.proto D sdks/rust/proto/grpc-gateway/LICENSE.txt D sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/annotations.proto D sdks/rust/proto/grpc-gateway/protoc-gen-openapiv2/options/openapiv2.proto D sdks/rust/proto/sdk/alpha/alpha.proto D sdks/rust/proto/sdk/beta/beta.proto D sdks/rust/proto/sdk/sdk.proto ``` (Note this sample output was also what happens when I just run this check on my desktop because the `rust` generation spews files as root.)
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: ac326eab-875e-46a3-b5e3-e2f66f50a3f9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
Kalaiselvi84
added
kind/cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a build step to verify that
make gen-all-sdk-grpchas run.Credit to @Kalaiselvi84 for original #3310
Sample output:
(Note this sample output was also what happens when I just run this
check on my desktop because the
rustgeneration spews files as root.)Along the way: Subsume #3348: Move the restapi folder GRPC_PORT off of the same port as the go folder tests. (In case it's not clear on review, the problem is the second invocation where we set GRPC_PORT to 9001, which is the same as the go folder.)