Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call gc.collect() when exiting the NDB runtime context #373

Closed
wants to merge 1 commit into from
Closed

fix: call gc.collect() when exiting the NDB runtime context #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions google/cloud/ndb/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
"""A client for NDB which manages credentials, project, namespace."""

import contextlib
import gc
import grpc
import os
import requests
Expand Down Expand Up @@ -200,6 +201,11 @@ def context(
# Finish up any work left to do on the event loop
context.eventloop.run()

# Work around bug where thread started by `google.auth` angers the
# Google App Engine Python 2.7 Runtime. See issue #336.
# https://github.com/googleapis/python-ndb/issues/336
gc.collect()

@property
def _http(self):
"""Getter for object used for HTTP transport.
Expand Down