Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: call gc.collect() when exiting the NDB runtime context #373

Closed
wants to merge 1 commit into from

Conversation

chrisrossi
Copy link
Contributor

This works around an issue where a thread started by google.auth
confuses the Google App Engine Python 2.7 runtime.

Fixes #336

This works around an issue where a thread started by `google.auth`
confuses the Google App Engine Python 2.7 runtime.

Fixes googleapis#336
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 20, 2020
@chrisrossi
Copy link
Contributor Author

It's worth noting that the issue being worked around is a product of a recent commit to google.auth:

googleapis/google-auth-library-python@0c33e9c#diff-ce8fd607d554afd5f68f90b463e6b6ea

This is the same proximal cause of #343. In the case of #343, there already seems to be a memory leak which is simply aggravated by that commit, turning it into a thread leak.

Might be worth some discussion with the google.auth library maintainers.

Copy link
Contributor

@cguardia cguardia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@chrisrossi
Copy link
Contributor Author

@busunkim96 This works around the issue with google.auth we were discussing. Do you anticipate a release of google.auth soon to fix this, or should we go ahead and merge this as a stopgap?

@busunkim96
Copy link
Contributor

@chrisrossi googleapis/google-auth-library-python#467 reverts the change. I'm just waiting for a review. The release will happen today or at the latest tomorrow morning.

@chrisrossi
Copy link
Contributor Author

Not going to merge since work-around is no longer needed. See: googleapis/google-auth-library-python#467

@chrisrossi chrisrossi closed this Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
4 participants