Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(samples): Fixed a typo in the readme #760

Merged
merged 3 commits into from
Apr 5, 2023

Conversation

shweta345
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shweta345 shweta345 requested review from a team as code owners March 31, 2023 03:42
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Mar 31, 2023
@dandhlee dandhlee changed the title docs: Fixed a typo in the readme chore(samples): Fixed a typo in the readme Mar 31, 2023
dandhlee
dandhlee previously approved these changes Mar 31, 2023
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dandhlee dandhlee added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 31, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 31, 2023
@shweta345 shweta345 mentioned this pull request Mar 31, 2023
4 tasks
@dandhlee dandhlee self-requested a review March 31, 2023 04:37
@dandhlee dandhlee dismissed their stale review March 31, 2023 04:38

Commit message does not align

@dandhlee
Copy link
Contributor

Ah. This has the same issue as #758.

On the commit message, it should just say chore rather than docs, as docs triggers a new release and sample updates don't need one.

Could you amend the commit message and push again? Don't need to create a new branch and a new PR, but if that helps then that works too.

@shweta345
Copy link
Contributor Author

@dandhlee Noted. I edited the message. Can you let me know if it amended properly?

@dandhlee
Copy link
Contributor

Can you amend and push? I still see it as docs: https://github.com/googleapis/python-bigtable/pull/760/commits

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Mar 31, 2023
@Mariatta Mariatta added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 5, 2023
@Mariatta Mariatta merged commit efe332c into googleapis:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. samples Issues that are directly related to samples. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants