Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixed a typo in the readme #758

Closed
wants to merge 1 commit into from

Conversation

shweta345
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@shweta345 shweta345 requested review from a team as code owners March 24, 2023 09:04
@shweta345 shweta345 requested a review from atulep March 24, 2023 09:04
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Mar 24, 2023
@shweta345 shweta345 changed the title Fixed a typo in the readme [docs]: Fixed a typo in the readme Mar 24, 2023
@conventional-commit-lint-gcf
Copy link

conventional-commit-lint-gcf bot commented Mar 24, 2023

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@Mariatta Mariatta changed the title [docs]: Fixed a typo in the readme docs: Fixed a typo in the readme Mar 24, 2023
@Mariatta Mariatta changed the title docs: Fixed a typo in the readme doc: Fixed a typo in the readme Mar 24, 2023
@Mariatta Mariatta changed the title doc: Fixed a typo in the readme docs: Fixed a typo in the readme Mar 24, 2023
@Mariatta
Copy link
Contributor

I think you need to amend your commit message and change it to start with docs:
See https://github.com/googleapis/python-bigtable/pull/758/checks?check_run_id=12265907486

@Mariatta
Copy link
Contributor

@shweta345 can you please amend the commit message such that it uses conventional commit?
It should start with docs:
https://github.com/googleapis/python-bigtable/pull/758/checks?check_run_id=12265907486

@shweta345
Copy link
Contributor Author

@Mariatta Apologies I was figuring out the amend command :)

@Mariatta
Copy link
Contributor

@shweta345
On command line with this branch checked out, do git commit --amend -m "your new commit message here"

This tutorial might help https://www.atlassian.com/git/tutorials/rewriting-history

@shweta345
Copy link
Contributor Author

@Mariatta I did amend the commit message using that tutorial. Thank you! Did it work or do I need to edit anything else?

@Mariatta
Copy link
Contributor

Then you need to push the change
Not sure of your set up, try

git push

or you may need

git push origin

@shweta345
Copy link
Contributor Author

@Mariatta Done with the push as well when I amended the commit message. I see that all the changes appear approved. I just wanted to know if there is anything else breaking that needs to be fixed. I am using Git through Terminal on my Mac.

@Mariatta
Copy link
Contributor

It doesn't look like the amended commit got pushed to this PR. We're still only seeing the commit where the commit message did not start with docs:.

Can you ensure that your local change gets pushed to this branch? (shweta345:shweta345-fixtypo) Perhaps it was pushed to a different branch. Or whether the git push command completed successfully?

@shweta345 shweta345 closed this Mar 31, 2023
@shweta345 shweta345 deleted the shweta345-fixtypo branch March 31, 2023 03:06
@shweta345
Copy link
Contributor Author

@Mariatta Finally resolved the issue and used VSCode for creating a new branch. #760. Thank you for all your help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants