This repository has been archived by the owner on Jan 26, 2018. It is now read-only.
Update NodeJS packaging patterns. #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| module.exports = function(relative) { | ||
| return path.join(__dirname, 'proto', relative); | ||
| }; | ||
| l |
|
Good to see so much dead code being removed! Please check failing test and one small note. Otherwise looks good. |
Current coverage is 91.70% (diff: 100%)@@ master #95 diff @@
==========================================
Files 3 3
Lines 729 711 -18
Methods 151 150 -1
Messages 0 0
Branches 112 111 -1
==========================================
+ Hits 644 652 +8
+ Misses 85 59 -26
Partials 0 0
|
|
LGTM |
- retire use_pbjs flag -- it's not used anymore, and it does not fit with the new pattern of Gapic code. - update the grpc package template: this fits with the proto packages used by gcloud-node. - update gax package template: this will work well with the new pattern of Gapic code, as you can see in googleapis/gapic-generator#392 or googleapis/google-cloud-node#1476
- add 'env' parameter to dependency_out protoc - modify fake_protoc not to fail on this test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fit with the new pattern of Gapic code.
used by gcloud-node.
pattern of Gapic code, as you can see in Modify NodeJS codegen to fit with gcloud-node design. gapic-generator#392
or Introduce Gapic-generated files for language API. google-cloud-node#1476