Skip to content
This repository has been archived by the owner on Jan 26, 2018. It is now read-only.

Bump version for new release #108

Merged
merged 1 commit into from
Sep 8, 2016
Merged

Bump version for new release #108

merged 1 commit into from
Sep 8, 2016

Conversation

geigerj
Copy link
Contributor

@geigerj geigerj commented Sep 7, 2016

No description provided.

@codecov-io
Copy link

Current coverage is 88.34% (diff: 100%)

Merging #108 into master will not change coverage

@@             master       #108   diff @@
==========================================
  Files             3          3          
  Lines           729        729          
  Methods         151        151          
  Messages          0          0          
  Branches        112        112          
==========================================
  Hits            644        644          
  Misses           85         85          
  Partials          0          0          

Powered by Codecov. Last update 5a4b086...962c0a1

@jmuk
Copy link
Contributor

jmuk commented Sep 7, 2016

I think it's better to wait for #109 too (I've also forgotten about #95, but I want to have it as well, if possible).

@geigerj
Copy link
Contributor Author

geigerj commented Sep 7, 2016

I needed to do this to fix artman remote stability issues -- I actually already published it to npm. Can we just bump to 0.8.5 for the outstanding issues?

@geigerj
Copy link
Contributor Author

geigerj commented Sep 8, 2016

In any case, I think there is probably a bit more discussion to be had on #109 due to googleapis/google-cloud-python#1893 (comment)

@jmuk
Copy link
Contributor

jmuk commented Sep 8, 2016

LGTM if you've already pushed a new package to npm -- but the bug of #109 looks like you'll have to push yet another version quite soon after it's merged.

@geigerj geigerj merged commit fc717b8 into googleapis:master Sep 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants