-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: replace ent
with html-entities
#813
fix: replace ent
with html-entities
#813
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
05c7cfb
to
95a532b
Compare
ent
with html-entities
ent
with html-entities
Unfortunately we can't accommodate this request because Node 18 is required for this package, and we're on Node 14. If there's another dependency that would do the trick that supports Node 14, that would work. Or, we can wait until our work to upgrade to Node 16, which should be in the next few months. |
@sofisl The error actually comes from one of the Line 46 in 9262359
I have the same error on the npm install --production --engine-strict --ignore-scripts --no-package-lock So the issue doesn't come from the PR |
ent
with html-entities
ent
with html-entities
Fixes #812
This PR replaces
ent
withhtml-entities
.BEGIN_COMMIT_OVERRIDE
fix: replace ent with html-entities
Release-As: 5.0.2
END_COMMIT_OVERRIDE