Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace ent with html-entities #813

Conversation

Drarig29
Copy link
Contributor

@Drarig29 Drarig29 commented Apr 15, 2024

Fixes #812

This PR replaces ent with html-entities.

BEGIN_COMMIT_OVERRIDE
fix: replace ent with html-entities
Release-As: 5.0.2
END_COMMIT_OVERRIDE

@Drarig29 Drarig29 requested a review from a team as a code owner April 15, 2024 21:23
Copy link

google-cla bot commented Apr 15, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Apr 15, 2024
@Drarig29 Drarig29 force-pushed the corentin.girard/remove-ent-using-deprecated-bundled-punycode branch from 05c7cfb to 95a532b Compare April 15, 2024 21:35
@Drarig29 Drarig29 changed the title [dep] Replace ent with html-entities chore(deps): replace ent with html-entities Apr 15, 2024
@sofisl
Copy link
Contributor

sofisl commented Apr 24, 2024

Unfortunately we can't accommodate this request because Node 18 is required for this package, and we're on Node 14. If there's another dependency that would do the trick that supports Node 14, that would work. Or, we can wait until our work to upgrade to Node 16, which should be in the next few months.

@Drarig29
Copy link
Contributor Author

Drarig29 commented Apr 26, 2024

@sofisl html-entities has zero dependencies.

The error actually comes from one of the devDependencies in this repository:

"@compodoc/compodoc": "^1.1.11",

I have the same error on the main branch if I run the same command as in the CI on Node 16:

npm install --production --engine-strict --ignore-scripts --no-package-lock

So the issue doesn't come from the PR

@Drarig29
Copy link
Contributor Author

@sofisl here is a PR to fix the bug: #814

@sofisl sofisl added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 26, 2024
@sofisl sofisl merged commit 7ec0a32 into googleapis:main Apr 26, 2024
14 checks passed
@Drarig29 Drarig29 deleted the corentin.girard/remove-ent-using-deprecated-bundled-punycode branch April 26, 2024 22:50
@sofisl sofisl changed the title chore(deps): replace ent with html-entities fix: replace ent with html-entities Apr 29, 2024
@sofisl sofisl added the release-please:force-run To run release-please label Apr 29, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 29, 2024
@sofisl sofisl added the release-please:force-run To run release-please label Apr 29, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 29, 2024
@sofisl sofisl added the release-please:force-run To run release-please label Apr 29, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 29, 2024
@sofisl sofisl added the release-please:force-run To run release-please label Apr 30, 2024
@release-please release-please bot removed the release-please:force-run To run release-please label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package ent isn't maintained anymore, and using deprecated punycode
3 participants