Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Package ent isn't maintained anymore, and using deprecated punycode #812

Closed
Drarig29 opened this issue Apr 15, 2024 · 2 comments · Fixed by #813
Closed

Package ent isn't maintained anymore, and using deprecated punycode #812

Drarig29 opened this issue Apr 15, 2024 · 2 comments · Fixed by #813
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Drarig29
Copy link
Contributor

Drarig29 commented Apr 15, 2024 •
edited
Loading

The ent package is still using the native punycode module which used to be bundled in Node.js < 21.

Starting in Node.js 21, this native module was deprecated (see official Node.js docs), and we now have to use the userland punycode.

And the following warning shows:

(node:1) [DEP0040] DeprecationWarning: The `punycode` module is deprecated. Please use a userland alternative instead.

Since the latest version of ent is 9-years-old and the repository was removed from GitHub, I think we could replace ent with another heavily-used package, e.g. html-entities.

Environment details

  • OS: macOS
  • Node.js version: v21.7.3
  • npm version: 10.5.0
  • @google-cloud/common version: 5.0.1

Steps to reproduce

  1. npm install @google-cloud/common
  2. node --trace-deprecation -e "require('@google-cloud/common')" (on Node.js 21)

I'll make a PR.
@Drarig29 Drarig29 added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Apr 15, 2024
@Drarig29
Copy link
Contributor Author

Solving this will close DataDog/datadog-ci#1283

@Drarig29 Drarig29 mentioned this issue Apr 15, 2024
Merged
@Drarig29
Copy link
Contributor Author

@sofisl Thanks for merging the PRs! 🙇

Could you publish a patch release of @google-cloud/common? Cheers!

@leoschweizer leoschweizer mentioned this issue Apr 30, 2024
Open
@Drarig29 Drarig29 mentioned this issue May 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace ent with html-entities Drarig29/nodejs-common
1 participant
@Drarig29