-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Record serialization/deserialization #1706
Merged
Merged
Changes from 1 commit
Commits
Show all changes
58 commits
Select commit
Hold shift + click to select a range
28d2e80
feat: Add support for java record serialization
eranl ae46486
Add support for java record serialization - use field annotations
eranl b50fc25
Add support for java record serialization - update doc
eranl d050e24
Add support for java record serialization - fix formatting
eranl de25226
Merge branch 'googleapis:main' into java-record
eranl 53aabf5
Add support for java record serialization - move test code to google-…
eranl 846917b
Merge branch 'googleapis:main' into java-record
eranl 7725ce9
Merge remote-tracking branch 'userRepo/java-record' into mila/test-re…
milaGGL f7ff7f3
Merge branch 'main' into mila/test-record
milaGGL 3fc7a23
check if CI running the new tests
milaGGL b6197d5
check if new pom setup leads to units(8) failure
milaGGL b155bee
try ignoring the ToStringTest
milaGGL 0bea023
remove var
milaGGL 91e1282
import missing types
milaGGL c6fd913
set javadoc source to java 17
milaGGL a85a466
update maven-javadoc-plugin at the root pom.xml
milaGGL 9e46f9c
Update pom.xml
milaGGL 5a70439
remove < release > in pom.xml
milaGGL 56e3031
Update pom.xml
milaGGL b5a465b
remove the build.sh changes
milaGGL 646ff81
Update pom.xml
milaGGL 9e99d2c
Revert "Update pom.xml"
milaGGL 3ea41cd
remove the <maven-compiler-plugin>
milaGGL 2c3f144
Revert "remove the <maven-compiler-plugin>"
milaGGL ec8d30c
Update build.sh
milaGGL 316df89
Update pom.xml
milaGGL e55907f
try conditionally run new tests via ci.yaml
milaGGL 7b2ce93
Update ci.yaml
milaGGL 353cbad
revert changes
milaGGL 09a79ee
spesify javadoc for test-jdk17
milaGGL bc1c06e
Update pom.xml
milaGGL c5bc13e
test: checking java 8 special setup is still needed or not
suztomo e556dcf
Update ci.yaml
suztomo d005e87
Merge remote-tracking branch 'origin/suztomo-patch-1' into mila/test-…
milaGGL 2d19310
Merge remote-tracking branch 'origin/suztomo-patch-1' into mila/test-…
milaGGL 8e26e85
remove changes in build.sh
milaGGL bd7d02d
Update pom.xml
milaGGL f3cfc66
Update pom.xml
milaGGL 080e338
Update pom.xml
milaGGL 54425c0
Update pom.xml
milaGGL f99e222
update ci.yaml to run javadoc on jdk8
milaGGL 46e0ede
Revert "update ci.yaml to run javadoc on jdk8"
milaGGL 9ec90dc
Update pom.xml
milaGGL 2bc0f5e
finalize pom.xml
milaGGL 11a8930
fix Instant-record merge (#1805)
eranl b395941
Merge branch 'main' into mila/test-record
milaGGL 37b9641
remove log, update copyright year
milaGGL 62aa37c
Add nested record & pojo types to test
milaGGL 124fc47
Update RecordDocumentReferenceTest.java
milaGGL 2f082c4
format
milaGGL b51506a
rename & relocate record test helper file
milaGGL d08cd6b
move PojoBeanMapper out, move errors to
milaGGL 0af8a9e
relocate serialization/deserialization files
milaGGL 5c94936
mark @InternalApi, move shared code to Util file,
milaGGL 48885ce
mark methods protected, reduce code duplication
milaGGL ef324e2
add class comment for EncodingUtil
milaGGL 28465af
remove EncodingUtil to make methods as private as possible
milaGGL 382d0aa
remove redundant constructor null check
milaGGL File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why move these methods from base class to a utility class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am moving out all util methods that are not specific to the base class or used in both child classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this is renamed to
validateDocumentIdType
to matchvalidateServerTimestampType
method.