Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Record serialization/deserialization #1706

Merged
merged 58 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
58 commits
Select commit Hold shift + click to select a range
28d2e80
feat: Add support for java record serialization
eranl Mar 3, 2023
ae46486
Add support for java record serialization - use field annotations
eranl Sep 23, 2023
b50fc25
Add support for java record serialization - update doc
eranl Sep 23, 2023
d050e24
Add support for java record serialization - fix formatting
eranl Oct 28, 2023
de25226
Merge branch 'googleapis:main' into java-record
eranl Oct 28, 2023
53aabf5
Add support for java record serialization - move test code to google-…
eranl Nov 3, 2023
846917b
Merge branch 'googleapis:main' into java-record
eranl Feb 23, 2024
7725ce9
Merge remote-tracking branch 'userRepo/java-record' into mila/test-re…
milaGGL Jun 13, 2024
f7ff7f3
Merge branch 'main' into mila/test-record
milaGGL Aug 28, 2024
3fc7a23
check if CI running the new tests
milaGGL Aug 28, 2024
b6197d5
check if new pom setup leads to units(8) failure
milaGGL Aug 28, 2024
b155bee
try ignoring the ToStringTest
milaGGL Aug 28, 2024
0bea023
remove var
milaGGL Aug 28, 2024
91e1282
import missing types
milaGGL Aug 28, 2024
c6fd913
set javadoc source to java 17
milaGGL Aug 29, 2024
a85a466
update maven-javadoc-plugin at the root pom.xml
milaGGL Aug 29, 2024
9e46f9c
Update pom.xml
milaGGL Aug 29, 2024
5a70439
remove < release > in pom.xml
milaGGL Aug 29, 2024
56e3031
Update pom.xml
milaGGL Aug 29, 2024
b5a465b
remove the build.sh changes
milaGGL Aug 29, 2024
646ff81
Update pom.xml
milaGGL Aug 29, 2024
9e99d2c
Revert "Update pom.xml"
milaGGL Aug 29, 2024
3ea41cd
remove the <maven-compiler-plugin>
milaGGL Aug 29, 2024
2c3f144
Revert "remove the <maven-compiler-plugin>"
milaGGL Aug 29, 2024
ec8d30c
Update build.sh
milaGGL Aug 29, 2024
316df89
Update pom.xml
milaGGL Aug 29, 2024
e55907f
try conditionally run new tests via ci.yaml
milaGGL Aug 30, 2024
7b2ce93
Update ci.yaml
milaGGL Aug 30, 2024
353cbad
revert changes
milaGGL Aug 30, 2024
09a79ee
spesify javadoc for test-jdk17
milaGGL Aug 30, 2024
bc1c06e
Update pom.xml
milaGGL Aug 30, 2024
c5bc13e
test: checking java 8 special setup is still needed or not
suztomo Aug 30, 2024
e556dcf
Update ci.yaml
suztomo Aug 30, 2024
d005e87
Merge remote-tracking branch 'origin/suztomo-patch-1' into mila/test-…
milaGGL Aug 30, 2024
2d19310
Merge remote-tracking branch 'origin/suztomo-patch-1' into mila/test-…
milaGGL Aug 30, 2024
8e26e85
remove changes in build.sh
milaGGL Aug 30, 2024
bd7d02d
Update pom.xml
milaGGL Aug 30, 2024
f3cfc66
Update pom.xml
milaGGL Aug 30, 2024
080e338
Update pom.xml
milaGGL Aug 30, 2024
54425c0
Update pom.xml
milaGGL Aug 30, 2024
f99e222
update ci.yaml to run javadoc on jdk8
milaGGL Aug 30, 2024
46e0ede
Revert "update ci.yaml to run javadoc on jdk8"
milaGGL Aug 30, 2024
9ec90dc
Update pom.xml
milaGGL Aug 30, 2024
2bc0f5e
finalize pom.xml
milaGGL Aug 30, 2024
11a8930
fix Instant-record merge (#1805)
eranl Sep 5, 2024
b395941
Merge branch 'main' into mila/test-record
milaGGL Sep 9, 2024
37b9641
remove log, update copyright year
milaGGL Sep 11, 2024
62aa37c
Add nested record & pojo types to test
milaGGL Sep 11, 2024
124fc47
Update RecordDocumentReferenceTest.java
milaGGL Sep 11, 2024
2f082c4
format
milaGGL Sep 11, 2024
b51506a
rename & relocate record test helper file
milaGGL Sep 12, 2024
d08cd6b
move PojoBeanMapper out, move errors to
milaGGL Sep 12, 2024
0af8a9e
relocate serialization/deserialization files
milaGGL Sep 12, 2024
5c94936
mark @InternalApi, move shared code to Util file,
milaGGL Sep 12, 2024
48885ce
mark methods protected, reduce code duplication
milaGGL Sep 13, 2024
ef324e2
add class comment for EncodingUtil
milaGGL Sep 13, 2024
28465af
remove EncodingUtil to make methods as private as possible
milaGGL Sep 13, 2024
382d0aa
remove redundant constructor null check
milaGGL Sep 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions google-cloud-firestore/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -321,5 +321,61 @@
</dependency>
</dependencies>
</profile>
<profile>
<!-- JDK17 set up for tests in src/test-jdk17 -->
<id>java17-test</id>
<activation>
<jdk>17</jdk>
</activation>
<build>
<plugins>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<executions>
<execution>
<id>add-test-source</id>
<phase>generate-test-sources</phase>
<goals>
<goal>add-test-source</goal>
</goals>
<configuration>
<sources>
<source>src/test-jdk17/java</source>
</sources>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<inherited>true</inherited>
<configuration>
<!-- Enable Java 17 for all sources so that Intellij picks the right language level -->
<source>17</source>
<release>17</release>
<compilerArgs>
<arg>-parameters</arg>
<arg>--add-opens=java.base/java.lang=ALL-UNNAMED</arg>
<arg>--add-opens=java.base/java.util=ALL-UNNAMED</arg>
</compilerArgs>
</configuration>
</plugin>
<plugin>
<!-- On CI, javadoc runs on java 17, but it sources java8 to compile and raises version conflict -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<configuration>
<sourceFileIncludes>
<include>src/test-jdk17/**/*.java</include>
</sourceFileIncludes>
<source>17</source>
<release>17</release>
</configuration>
</plugin>
</plugins>
</build>
</profile>
</profiles>
</project>
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import com.google.api.gax.rpc.ApiException;
import com.google.api.gax.rpc.ApiExceptions;
import com.google.api.gax.rpc.UnaryCallable;
import com.google.cloud.firestore.encoding.CustomClassMapper;
import com.google.cloud.firestore.spi.v1.FirestoreRpc;
import com.google.cloud.firestore.telemetry.TraceUtil;
import com.google.cloud.firestore.telemetry.TraceUtil.Scope;
Expand Down
Loading
Loading