Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'keys_only' method to Query. #489

Merged
merged 1 commit into from
Jan 6, 2015
Merged

Add 'keys_only' method to Query. #489

merged 1 commit into from
Jan 6, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 6, 2015

Sets the projection to include only entity keys.

Supercedes #466.

Sets the projection to include only entity keys.

Supercedes #466.
@dhermes
Copy link
Contributor

dhermes commented Jan 6, 2015

This mostly LGTM but feels a bit different than the other setters (I'm probably just paranoid).

@tseaver
Copy link
Contributor Author

tseaver commented Jan 6, 2015

We already have a split between the "property" setters (e.g., order, projection) and the additive filter. The keys_only one is really just a convenience shortcut for query.projection = ['__key__'] (or maybe an encapsulation of the "special" __key__ name).

@dhermes
Copy link
Contributor

dhermes commented Jan 6, 2015

Yeah still LGTM. I wonder if down the road it'd be worth having a keys_only fetch which throws away the do-nothing Entity wrapper in a __key__ projection.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 0c5cef5 on tseaver:466-query-keys_only into 8727c0d on GoogleCloudPlatform:master.

tseaver added a commit that referenced this pull request Jan 6, 2015
@tseaver tseaver merged commit 626adca into googleapis:master Jan 6, 2015
@tseaver tseaver deleted the 466-query-keys_only branch January 6, 2015 17:35
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
parthea pushed a commit that referenced this pull request Aug 15, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@56da63e
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
parthea pushed a commit that referenced this pull request Oct 21, 2023
Source-Link: googleapis/synthtool@cb96037
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:2d816f26f728ac8b24248741e7d4c461c09764ef9f7be3684d557c9632e46dbd

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants