Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keys function to Query. #466

Closed
wants to merge 2 commits into from
Closed

Add keys function to Query. #466

wants to merge 2 commits into from

Conversation

adieu
Copy link

@adieu adieu commented Dec 26, 2014

Keys only query are quite useful. Adding .projection(['__key__']) every time doesn't look very tidy.
This helper function makes keys only query easier to use.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) when pulling 5bbf856 on adieu:keys-only into b343acf on GoogleCloudPlatform:master.

@tseaver
Copy link
Contributor

tseaver commented Dec 30, 2014

The feature looks reasonable. Can you please add one or more tests which exercise it?

@adieu
Copy link
Author

adieu commented Dec 31, 2014

Sure, I'll add it later today.

@silvolu silvolu added the cla: no This human has *not* signed the Contributor License Agreement. label Dec 31, 2014
@dhermes
Copy link
Contributor

dhermes commented Dec 31, 2014

Also @adieu have you signed the CLA referenced in CONTRIBUTING?

@adieu
Copy link
Author

adieu commented Dec 31, 2014

Not yet. Will do that too.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 349af40 on adieu:keys-only into b343acf on GoogleCloudPlatform:master.

@adieu
Copy link
Author

adieu commented Dec 31, 2014

I've signed the CLA and added test for my code. Thank you.
Should I merge those two commits into a single one?

@tseaver
Copy link
Contributor

tseaver commented Dec 31, 2014

No need to squash your commits. @silvolu, are you verifying CLA manually, or is there a bot which hasn't kicked in yet?

@silvolu silvolu added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 5, 2015
@silvolu
Copy link
Contributor

silvolu commented Jan 5, 2015

Manually :/

@tseaver
Copy link
Contributor

tseaver commented Jan 5, 2015

LGTM, except that it will conflict with the big in-progress changes in #487.

@dhermes dhermes mentioned this pull request Jan 6, 2015
Merged
@adieu
Copy link
Author

adieu commented Jan 6, 2015

I could contribute another patch after it got merged. Or the keys function could be added directly by one of the core developers since it's just a helper function with few lines of code.

I did't follow the development recently. Might contribute another PR about multiple insert with a single http request if it's not covered with recent changes.

@tseaver tseaver mentioned this pull request Jan 6, 2015
Merged
@tseaver
Copy link
Contributor

tseaver commented Jan 6, 2015

#489 adds the feature in a way that doesn't class with the new semantics.

@tseaver tseaver closed this Jan 6, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt (#466)
5b1e1f2 
Source-Link: googleapis/synthtool@e3a1277
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt (#466)
026f0dd 
Source-Link: googleapis/synthtool@e3a1277
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt (#466)
9bd555e 
Source-Link: googleapis/synthtool@e3a1277
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt (#466)
db7f2fc 
Source-Link: googleapis/synthtool@e3a1277
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Jun 4, 2023
@gcf-owl-bot
chore(python): upgrade gcp-releasetool in .kokoro [autoapprove] (#466)
e4fcd04 
Source-Link: https://togithub.com/googleapis/synthtool/commit/5f2a6089f73abf06238fe4310f6a14d6f6d1eed3
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8555f0e37e6261408f792bfd6635102d2da5ad73f8f09bcb24f25e6afb5fac97
parthea pushed a commit that referenced this pull request Aug 15, 2023
@release-please
chore(main): release 1.13.5 (#466)
e4d8e4b 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot @parthea
chore(python): set coverage level to 100% (#466)
f95a0f4 
* chore(python): use cov_level in unittest gh action

Source-Link: googleapis/synthtool@e5aaa84
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:d22cd2ddce65fdac6986f115563faf2fc81482b09dfbea83ac2808c92ecfdff0

* set coverage to 100%

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update all dependencies (#466)
cd2fad1
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore(python): exclude path in renovate.json [autoapprove] (#466)
b901c56 
Source-Link: googleapis/synthtool@4826337
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:60a63eddf86c87395b4bb394fdddfe30f84a7726ee8fe0b758ea132c2106ac75

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v3.4.1 (#466)
43efcd0
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore(deps): update actions/setup-python action to v4 [autoapprove] (#…
793f31d 
…466)

Source-Link: googleapis/synthtool@8e55b32
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:c6c965a4bf40c19011b11f87dbc801a66d3a23fbc6704102be064ef31c51f1c3
parthea added a commit that referenced this pull request Oct 21, 2023
@renovate-bot @gcf-owl-bot @parthea
chore(deps): update all dependencies (#466)
cdabbd6 
* chore(deps): update all dependencies

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* revert

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
chore(python): update dependencies in .kokoro/requirements.txt (#466)
d43248f 
Source-Link: googleapis/synthtool@e3a1277
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:452901c74a22f9b9a3bd02bce780b8e8805c97270d424684bff809ce5be8c2a2

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@adieu @coveralls @tseaver @dhermes @silvolu