-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use lower-case gRPC header keys #2212
Conversation
As upper-case letters are illegal per http2 spec.
@yang-g Thanks for the fix! Travis is going to barf whenever it gets around to running, because the unit tests assert the upper-case field names: ======================================================================
FAIL: test___call__ (gcloud.test__helpers.TestMetadataPlugin)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/tseaver/projects/agendaless/Google/src/gcloud-python/gcloud/test__helpers.py", line 845, in test___call__
self.assertEqual(callback_args, [(cb_headers, None)])
AssertionError: Lists differ: [([('authorization', 'Bearer F... != [([('Authorization', 'Bearer F...
First differing element 0:
([('authorization', 'Bearer FOOBARBAZ'), ('user-agent', 'USER_AGENT')], None)
([('Authorization', 'Bearer FOOBARBAZ'), ('User-agent', 'USER_AGENT')], None)
- [([('authorization', 'Bearer FOOBARBAZ'), ('user-agent', 'USER_AGENT')], None)]
? ^ ^
+ [([('Authorization', 'Bearer FOOBARBAZ'), ('User-agent', 'USER_AGENT')], None)]
? ^ ^ Can you please update the PR accordingly? @dhermes, @daspecster For future reference, here is the HTTP/2 spec reference which mandates lower-case for header field names (I was completely unaware of that requirement). |
I cancelled the not-yet-started Travis build after verifying that it would fail. |
@yang-g I restarted the build. Sorry for my haste in cancelling -- Travis has been so glacially slow lately that we've been minimizing "known broken" jobs in the queue. |
@tseaver I think Travis have sorted out their issues |
@yang-g Thank you again! |
As upper-case letters are illegal per http2 spec.