Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to ensure we use lower-case gRPC header keys #334

Closed
omaray opened this issue Aug 30, 2016 · 1 comment
Closed

Need to ensure we use lower-case gRPC header keys #334

omaray opened this issue Aug 30, 2016 · 1 comment
Assignees
Labels
🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@omaray
Copy link

omaray commented Aug 30, 2016

This might be a no-op, but please double check. Filing this issue just in case.

We need to ensure that all headers used for gRPC are written in lower-case. Please review this Pull Request for reference of what needs to be updated.

Again, perhaps this doesn't apply to your language. Feel free to comment and close the issue (after you double checking).

@broady
Copy link
Contributor

broady commented Aug 30, 2016

Yup, handled by grpc-go.

@omaray, you should probably file these bugs against the gRPC library rather than users of gRPC. gRPC should handle this automatically, or at least return an error if the header keys are not lowercased.

@broady broady closed this as completed Aug 30, 2016
@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

3 participants