Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BigQuery: expose numDmlAffectedRows in query results #2920

Closed
tswast opened this issue Jan 5, 2017 · 3 comments
Closed

BigQuery: expose numDmlAffectedRows in query results #2920

tswast opened this issue Jan 5, 2017 · 3 comments
Assignees
@tseaver
Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@tswast
Copy link
Contributor

tswast commented Jan 5, 2017

See: https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs/query#numDmlAffectedRows

It is marked as experimental. This is because DML statements are currently in beta for BigQuery.

This will be needed to correctly implement cursor.rowcount for DB-API support #2434
@tswast tswast added api: bigquery Issues related to the BigQuery API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jan 5, 2017
@lukesneeringer
Copy link
Contributor

Hey Tim,
Has this come out of the experimental phase yet?

@danoscarmike danoscarmike added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Feb 28, 2017
@tseaver
Copy link
Contributor

tseaver commented Mar 6, 2017

DML Docs still show beta status.

@tswast
Copy link
Contributor Author

tswast commented May 26, 2017

DML is GA now (for non-partitioned tables), by the way.
https://cloud.google.com/bigquery/docs/reference/standard-sql/data-manipulation-language

@tseaver tseaver mentioned this issue May 31, 2017
Merged
tseaver added a commit that referenced this issue May 31, 2017
@tseaver
Add 'Query.num_dml_affected_rows' property. (#3460)
7e73e78 
Read-only, set from servier-provided 'numDmlAffectedRows' field.

Closes #2920.
@tseaver tseaver mentioned this issue Jun 26, 2017
Merged
@tswast tswast mentioned this issue Aug 3, 2017
Closed
landrito pushed a commit to landrito/google-cloud-python that referenced this issue Aug 21, 2017
@tseaver @landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
9e44ba0 
Read-only, set from servier-provided 'numDmlAffectedRows' field.

Closes googleapis#2920.
landrito pushed a commit to landrito/google-cloud-python that referenced this issue Aug 22, 2017
@tseaver @landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
3d6adcd 
Read-only, set from servier-provided 'numDmlAffectedRows' field.

Closes googleapis#2920.
landrito pushed a commit to landrito/google-cloud-python that referenced this issue Aug 22, 2017
@tseaver @landrito
Add 'Query.num_dml_affected_rows' property. (googleapis#3460)
84bb5d0 
Read-only, set from servier-provided 'numDmlAffectedRows' field.

Closes googleapis#2920.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tseaver tseaver

Labels
api: bigquery Issues related to the BigQuery API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lukesneeringer @tseaver @tswast @danoscarmike