New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add properties for new job statistics #3721

Closed

tseaver wants to merge 15 commits into googleapis:master from tseaver:3706-bigquery-new-job-statistics

Contributor

tseaver commented Aug 2, 2017

Closes #3706.

Note for reviewers: commit-by-commit might be an easier path.

tseaver added 14 commits

August 2, 2017 17:30


          Add 'QueryJob.query_plan' property.

a3dcf11


          Add 'QueryJob.total_bytes_processed' property.

691f221


          Add 'QueryJob.total_bytes_billed' property.

913db1c


          Add 'QueryJob.billing_tier' property.

9e88976


          Add 'QueryJob.cache_hit' property.

53ed914


          Add 'Client._clone' helper.

941ad92

Eases construction of a client with a new project, but the same
credentials / http implementation.


          Add 'QueryJob.referenced_tables' property.

1e34f2d


          Add 'QueryJob.num_dml_affected_rows' property.

3042da1


          Add 'QueryJob.schema' property.

da1112a


          Add 'QueryJob.undeclared_schema_parameters' property.

6009e30


          Add 'QueryJob.statement_type' property.

419c8b6


          Add 'ExtractTableToStorageJob.destination_uri_file_counts' property.

0f443ea


          Factor out job-specific stats helper.

ed3aacc


          Coverage.

6380fb9

tseaver added api: bigquery type: feature request labels

tseaver requested review from theacodes and dhermes

August 2, 2017 23:27

googlebot added the cla: yes label

Contributor

theacodes commented Aug 2, 2017

I'm going to defer to @tswast for this.


          Fix docs build.

0cd8fa5

tswast requested changes

View reviewed changes

Contributor

tswast left a comment

Thanks! A couple suggestions.

bigquery/google/cloud/bigquery/job.py

+                      See:
+                      https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.queryPlan
+                      :rtype: list of dict

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/job.py

@@ @@ -1277,6 +1297,170 @@ def from_api_repr(cls, resource, client): @@
                       job._set_properties(resource)
                       return job
+                  @property
+                  def query_plan(self):

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/client.py

                           project=project, credentials=credentials, _http=_http)
                       self._connection = Connection(self)
+                  def _clone(self, project):

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/job.py

+                          t_project = table['projectId']
+                          t_client = clients_by_project.get(t_project)
+                          if t_client is None:
+                              t_client = client._clone(t_project)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/job.py Outdated

@@ @@ -1390,6 +1390,20 @@ def referenced_tables(self): @@
                       return tables
+                  @property
+                  def num_dml_affected_rows(self):

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/job.py Outdated

+                      See:
+                      https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.schema
+                      :rtype: list of :class:`~google.cloud.bigquery.schema.SchemaField

This comment was marked as spam.

Sign in to view

bigquery/google/cloud/bigquery/job.py

+                      See:
+                      https://cloud.google.com/bigquery/docs/reference/rest/v2/jobs#statistics.query.undeclaredQueryParamters
+                      :rtype: list of dict

This comment was marked as spam.

Sign in to view

dhermes reviewed

View reviewed changes

bigquery/google/cloud/bigquery/client.py

+                      :returns: a new instance, bound to the supplied project, using
+                                the same credentials / http object as this instance.
+                      """
+                      return self.__class__(project, self._credentials, self._http)

This comment was marked as spam.

Sign in to view

tseaver mentioned this pull request

Bigquery Beta 2 Tracking #3746

Closed

18 tasks

Contributor Author

tseaver commented Aug 12, 2017

@tswast I'm going to break this up into separate PRs, targeting the bigquery-b2 branch.

tseaver closed this

This was referenced Aug 12, 2017

Add 'QueryJob.query_plan' property. #3799

Merged

Add new scalar statistics properties to 'QueryJob' #3800

Merged

Add 'QueryJob.referenced_tables' property. #3801

Merged

Add 'QueryJob.undeclared_query_parameters' property. #3802

Merged

tseaver mentioned this pull request

Add 'ExtractTableStorageJob.destination_uri_file_counts' property. #3803

Merged

tseaver deleted the 3706-bigquery-new-job-statistics branch

September 8, 2017 12:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery cla: yes type: feature request