Skip to content

Commit

Permalink
Address review comments:
Browse files Browse the repository at this point in the history
  • Loading branch information
tseaver committed Aug 9, 2016
1 parent d4b6e13 commit 1e6996e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions gcloud/bigquery/table.py
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ def partitioning_type(self, value):
:type value: str
:param value: partitioning type only "DAY" is currently supported
"""
if value not in ['DAY', None]:
if value not in ('DAY', None):
raise ValueError("value must be one of ['DAY', None]")

if value is None:
Expand Down Expand Up @@ -242,10 +242,10 @@ def partition_expiration(self, value):
self._properties['timePartitioning'].pop('expirationMs')
else:
try:
self._properties["timePartitioning"]["expirationMs"] = value
self._properties['timePartitioning']['expirationMs'] = value
except KeyError:
self._properties['timePartitioning'] = {'type': "DAY"}
self._properties["timePartitioning"]["expirationMs"] = value
self._properties['timePartitioning'] = {'type': 'DAY'}
self._properties['timePartitioning']['expirationMs'] = value

@property
def description(self):
Expand Down

0 comments on commit 1e6996e

Please sign in to comment.