-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slightly more explicit coverage for partition-related methods. #2060
Conversation
@dhermes PTAL. |
@@ -245,25 +209,22 @@ def partitioning_type(self, value): | |||
:type value: str | |||
:param value: partitioning type only "DAY" is currently supported | |||
""" | |||
if not (isinstance(value, six.string_types) | |||
and value.upper() == "DAY") and value is not None: | |||
if value not in ['DAY', None]: |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
New changes LGTM. I wonder why |
Reduces lines in 'test_table.py' to appease pylint's arbitrary ceiling.
I've rebased to |
@tseaver FYI Travis has passed |
Follow-on to #2058.