Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correctly use classes in markdown & fix site bug #714

Merged

Conversation

stephenplusplus
Copy link
Contributor

Fixes #712
Fixes #713

@jacobsa discovered two bugs:

  1. Our docs.md code formatting was broken: https://github.com/GoogleCloudPlatform/gcloud-node/blob/2ad51ae/docs/authorization.md
  2. Our authorization page had been showing the same code block for both examples.

Thanks, @jacobsa!

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2015
@@ -4,7 +4,7 @@ With `gcloud-node` it's incredibly easy to get authorized and start using Google

If you are running this client on Google Compute Engine, we handle authorization for you with no configuration. You just need to make sure that when you [set up the GCE instance][gce-how-to], you add the correct scopes for the APIs you want to access.

```js hljs-class
```hljs-class

This comment was marked as spam.

@jgeewax
Copy link
Contributor

jgeewax commented Jul 10, 2015

Nice catch - subtle fixes... LGTM

stephenplusplus added a commit that referenced this pull request Jul 10, 2015
docs: correctly use classes in markdown & fix site bug
@stephenplusplus stephenplusplus merged commit a78d438 into googleapis:master Jul 10, 2015
sofisl added a commit that referenced this pull request Sep 27, 2022
* build!: Update library to use Node 12

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Sep 27, 2022
🤖 I have created a release *beep* *boop*
---


## [4.0.0](googleapis/nodejs-video-intelligence@v3.4.1...v4.0.0) (2022-06-29)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#714)
* field ObjectTrackingAnnotation.segment moved into oneof, added track_id (#704)

### Features

* field ObjectTrackingAnnotation.segment moved into oneof, added track_id ([#704](googleapis/nodejs-video-intelligence#704)) ([b55757b](googleapis/nodejs-video-intelligence@b55757b))
* support regapic LRO ([#720](googleapis/nodejs-video-intelligence#720)) ([903e5ca](googleapis/nodejs-video-intelligence@903e5ca))


### Bug Fixes

* fixes for dynamic routing and streaming descriptors ([#716](googleapis/nodejs-video-intelligence#716)) ([853d91e](googleapis/nodejs-video-intelligence@853d91e))


### Build System

* update library to use Node 12 ([#714](googleapis/nodejs-video-intelligence#714)) ([a9fbbcd](googleapis/nodejs-video-intelligence@a9fbbcd))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl added a commit that referenced this pull request Nov 9, 2022
* build!: Update library to use Node 12

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 9, 2022
🤖 I have created a release *beep* *boop*
---


## [4.0.0](googleapis/nodejs-video-intelligence@v3.4.1...v4.0.0) (2022-06-29)


### ⚠ BREAKING CHANGES

* update library to use Node 12 (#714)
* field ObjectTrackingAnnotation.segment moved into oneof, added track_id (#704)

### Features

* field ObjectTrackingAnnotation.segment moved into oneof, added track_id ([#704](googleapis/nodejs-video-intelligence#704)) ([b55757b](googleapis/nodejs-video-intelligence@b55757b))
* support regapic LRO ([#720](googleapis/nodejs-video-intelligence#720)) ([903e5ca](googleapis/nodejs-video-intelligence@903e5ca))


### Bug Fixes

* fixes for dynamic routing and streaming descriptors ([#716](googleapis/nodejs-video-intelligence#716)) ([853d91e](googleapis/nodejs-video-intelligence@853d91e))


### Build System

* update library to use Node 12 ([#714](googleapis/nodejs-video-intelligence#714)) ([a9fbbcd](googleapis/nodejs-video-intelligence@a9fbbcd))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this pull request Nov 10, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Nov 17, 2022
…714) (#717)

* fix(compute): revert proto3_optional, required removal on parent_id (#714)

Source-Link: googleapis/googleapis@6b3fdce

Source-Link: googleapis/googleapis-gen@832dbe9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiODMyZGJlOTk4ODc4ZDg2MTlkNmI0MGZlNTdjNmQyY2M2ZTdkYzkwYyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this pull request Jan 10, 2023
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants