Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect GitHub Markdown syntax. #713

Closed
wants to merge 1 commit into from

Conversation

jacobsa
Copy link

@jacobsa jacobsa commented Jul 9, 2015

This caused the code samples to look totally broken in the GitHub viewer.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2015
@jacobsa
Copy link
Author

jacobsa commented Jul 9, 2015

Oops, I guess hljs-class is not intended to be part of the code. But it screws up GitHub's viewer. What's the intent of including it?

@stephenplusplus
Copy link
Contributor

Wow, amazing that we missed this. The hljs-class is picked up by our docs site in the hljsClass directive: https://github.com/GoogleCloudPlatform/gcloud-node/blob/2ad51ae1de8fb3fd21bd0f437a6877e6ec0511c7/docs/site/components/subpage/subpage-directive.js#L40. I found a solution that will fix the issues. More details in a PR coming soon!

sofisl pushed a commit that referenced this pull request Nov 10, 2022
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 392067151

Source-Link: googleapis/googleapis@06345f7

Source-Link: googleapis/googleapis-gen@95882b3
sofisl pushed a commit that referenced this pull request Nov 17, 2022
sofisl added a commit that referenced this pull request Jan 10, 2023
* build!: Update library to use Node 12
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants