New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speech partial veneer #2459

Merged

stephenplusplus merged 5 commits into googleapis:master from lukesneeringer:speech-partial-veneer

Jul 15, 2017

Contributor

lukesneeringer commented Jul 15, 2017

Supercedes #2421.

lukesneeringer added 2 commits

July 14, 2017 16:54


          This commit adds the Speech "partial Veneer", which shifts us to mostly

e322f73

exposing the auto-gen surface, with some manual glue code.

See googleapis#2421 for the details. This PR is the canonical one instead in order
to decouple it from Vision (which I based the previous branch off of).


          Do not lint auto-gen packages.

98e12a6

lukesneeringer requested a review from stephenplusplus

July 15, 2017 00:02

googlebot added the cla: yes label

stephenplusplus reviewed

View reviewed changes

packages/speech/package.json Outdated

                 "name": "@google-cloud/speech",
-                "version": "0.9.4",
+                "version": "0.10.0",

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed

View reviewed changes

packages/speech/package.json Outdated

-                  "proxyquire": "^1.7.10",
-                  "tmp": "^0.0.31",
-                  "uuid": "^3.0.1"
+                  "intelli-espower-loader": "^1.0.1",

This comment was marked as spam.

Sign in to view

stephenplusplus reviewed

View reviewed changes

packages/speech/package.json Outdated

-                  "uuid": "^3.0.1"
+                  "intelli-espower-loader": "^1.0.1",
+                  "mocha": "^3.2.0",
+                  "nyc": "^10.3.0",

This comment was marked as spam.

Sign in to view


          ignore helper files from docs

googlebot added cla: no and removed cla: yes labels


          ignore speech from system tests

54d7772

stephenplusplus reviewed

View reviewed changes

packages/speech/src/helpers.js Outdated


		requestStream,

		// Pass through the results.

This comment was marked as spam.

Sign in to view

googleapis deleted a comment from googlebot

stephenplusplus reviewed

View reviewed changes

packages/speech/src/helpers.js Outdated

+                 *
+                 * @example
+                 *
+                 * var client = require('@google-cloud/speech')();

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view


          address my feedback

ac55bc1

googleapis deleted a comment from googlebot

coveralls commented Jul 15, 2017

Coverage decreased (-0.1%) to 99.89% when pulling ac55bc1 on lukesneeringer:speech-partial-veneer into 4b5158e on GoogleCloudPlatform:master.

stephenplusplus merged commit 80d5c3b into googleapis:master

lukesneeringer deleted the speech-partial-veneer branch

July 15, 2017 01:52

jmdobry reviewed

View reviewed changes

packages/speech/src/helpers.js

+               *   onto the pure GAPIC.
+               */
+              module.exports = () => {
+                var methods = {};

This comment was marked as spam.

Sign in to view

snyk-bot mentioned this pull request

[Snyk] Upgrade @google-cloud/speech from 0.6.0 to 0.11.0 Chatie/stt#20

Open

sofisl pushed a commit that referenced this pull request


          Speech partial veneer (#2459)

c2f0206

This commit adds the Speech "partial Veneer", which shifts us to mostly
exposing the auto-gen surface, with some manual glue code.

sofisl pushed a commit that referenced this pull request


          Speech partial veneer (#2459)

24efe92

This commit adds the Speech "partial Veneer", which shifts us to mostly
exposing the auto-gen surface, with some manual glue code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: no