Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Speech Partial Veneer #2421

Closed
wants to merge 30 commits into from
Closed

Speech Partial Veneer #2421

wants to merge 30 commits into from

Conversation

swcloud
Copy link
Contributor

@swcloud swcloud commented Jun 30, 2017 •
edited
Loading

This is the new surface with breaking changes.

Luke Sneeringer and others added 23 commits May 10, 2017 14:31
Vision Partial Veneer for NodeJS
ab565ea
Fix to the single-feature methods.
070807e
Vision semi-GAPIC.
553bcd1
Add GAPIC tests.
83611e1
Minor updates (mostly lint fixes).
2c00c70
Fix (and exclude) linting as appropriate, change to power-assert.
6d5684e
Node 4 does not support array destructuring.
41ed049
Add filename support.
e5ffcf3
@lukesneeringer
Merge branch 'master' into vision-semi-gapic
981e861
Support ES6 in snippet tests.
53e087a
Merge branch 'vision-semi-gapic' of github.com:lukesneeringer/google-…
bbaf415 
…cloud-node into vision-semi-gapic
Shift to async readFile.
04aca35
Nuke the manual layer from space.
7207adf
Update lint.
c699d90
Move to .nycrc file.
2459348
Helpers now at full coverage.
667f6a4
Update system tests.
6f3caf6
Merge branch 'public-master' into vision-semi-gapic
da27074
Play with Vision example a bit.
5dfd111
WIP
cb1f005
Fix the last unit test.
3e79c34
@swcloud
Add support for stream pipe
48e47e2
@swcloud
sync with auto-gen
3da9fd6
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2017
@swcloud swcloud changed the title Speech semi gapic Speech Partial Veneer Jun 30, 2017
@stephenplusplus stephenplusplus added the api: speech Issues related to the Speech-to-Text API. label Jun 30, 2017
stephenplusplus
stephenplusplus suggested changes Jul 14, 2017
View reviewed changes
packages/speech/package.json
},
"scripts": {
"publish-module": "node ../../scripts/publish.js speech",
"test": "mocha test/*.js",
"system-test": "mocha system-test/*.js --no-timeouts --bail"
"smoke-test": "mocha smoke-test/*.js --timeout 5000",

This comment was marked as spam.

Sign in to view

packages/speech/smoke-test/speech_smoke_test.js
var sampleRateHertz = 44100;
var encoding = speech.v1.types.RecognitionConfig.AudioEncoding.FLAC;
var config = {
languageCode : languageCode,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/speech/smoke-test/speech_smoke_test.js
};
client.recognize(request).then(function(responses) {
var response = responses[0];
console.log(response);

This comment was marked as spam.

Sign in to view

packages/speech/smoke-test/speech_smoke_test.js

describe('SpeechSmokeTest', function() {

it('successfully makes a call to the service', function(done) {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/speech/test/helpers.test.js
});

describe('streamingRecognize', () => {
it('writes the config to the resulting stream', () => {

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/speech/package.json
"proxyquire": "^1.7.10",
"tmp": "^0.0.31",
"uuid": "^3.0.1"
"intelli-espower-loader": "^1.0.1",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

packages/speech/package.json
"name": "@google-cloud/speech",
"version": "0.9.4",
"version": "0.10.0",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

package.json
@@ -13,6 +13,7 @@
"extend": "^3.0.0",
"glob": "^5.0.9",
"globby": "^3.0.1",
"intelli-espower-loader": "^1.0.1",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

package.json
"propprop": "^0.3.1",
"semver": "^5.3.0",
"shelljs": "^0.7.3",
"sinon": "^2.2.0",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

package.json
@@ -25,9 +26,11 @@
"multiline": "^1.0.2",
"nyc": "^10.3.0",
"package-json": "^2.4.0",
"power-assert": "^1.4.2",

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@stephenplusplus stephenplusplus mentioned this pull request Jul 14, 2017
Merged
3 tasks
@stephenplusplus
Copy link
Contributor

Vision doesn't have any "docs" files generated.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 14, 2017
@googleapis googleapis deleted a comment from googlebot Jul 14, 2017
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

stephenplusplus
stephenplusplus reviewed Jul 14, 2017
View reviewed changes
packages/vision/package.json
@@ -66,17 +66,22 @@
"devDependencies": {

This comment was marked as spam.

Sign in to view

package.json
@@ -13,6 +13,7 @@
"extend": "^3.0.0",
"glob": "^5.0.9",
"globby": "^3.0.1",
"intelli-espower-loader": "^1.0.1",

This comment was marked as spam.

Sign in to view

lukesneeringer
lukesneeringer reviewed Jul 14, 2017
View reviewed changes
packages/speech/test/helpers.test.js
'use strict';

var assert = require('assert');
var sinon = require('sinon');

This comment was marked as spam.

Sign in to view

lukesneeringer added a commit to lukesneeringer/google-cloud-node that referenced this pull request Jul 15, 2017
@lukesneeringer
This commit adds the Speech "partial Veneer", which shifts us to mostly
e322f73 
exposing the auto-gen surface, with some manual glue code.

See googleapis#2421 for the details. This PR is the canonical one instead in order
to decouple it from Vision (which I based the previous branch off of).
@lukesneeringer
Copy link
Contributor

I just realized (not sure how I just realized) that this is entangled with Vision. Sending a new PR with just this.

@lukesneeringer lukesneeringer mentioned this pull request Jul 15, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukesneeringer lukesneeringer lukesneeringer approved these changes

@stephenplusplus stephenplusplus stephenplusplus requested changes

Assignees
No one assigned
Labels
api: speech Issues related to the Speech-to-Text API. cla: no This human has *not* signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swcloud @stephenplusplus @googlebot @lukesneeringer