Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why don't we have a section in the docs under storage called Acl ? #573

Closed
jgeewax opened this issue May 9, 2015 · 4 comments
Closed

Why don't we have a section in the docs under storage called Acl ? #573

jgeewax opened this issue May 9, 2015 · 4 comments
Assignees
@ryanseys
Labels
type: question Request for information or clarification. Not an issue.
Milestone
Core Future

Comments

@jgeewax
Copy link
Contributor

jgeewax commented May 9, 2015

Seems that http://googlecloudplatform.github.io/gcloud-node/#/docs/v0.14.0/storage/acl is generated, but we don't have an item in the sidebar. Is that because we inlined the ACL-related methods into the Bucket/File as whatever.acl.method ?
@jgeewax jgeewax added type: question Request for information or clarification. Not an issue. docs labels May 9, 2015
@jgeewax jgeewax added this to the Core Future milestone May 9, 2015
@ryanseys
Copy link
Contributor

Yep. We don't expose Acl directly to the user, only through Bucket and File, which use this shared Acl class that you're talking about here.

@jgeewax
Copy link
Contributor Author

jgeewax commented May 11, 2015

That makes sense.

So should we expose this to the user? Or is it better left as a hidden mix-in style class?

@stephenplusplus
Copy link
Contributor

I only like keeping that page hidden because I worry it would be confusing for developers to differentiate between the file / bucket scenarios, then the default Bucket object. Keeping them doc'd on their module pages lets us have more control how the concepts are presented to the user.

But if you guys think it's more helpful having the ACL page as well, I'm cool with it.

@jgeewax jgeewax changed the title Why don't we have a section int he docs under storage called Acl ? Why don't we have a section in the docs under storage called Acl ? May 14, 2015
@jgeewax
Copy link
Contributor Author

jgeewax commented May 14, 2015

I have no preference at all - I think we're fine as is...

chingor13 pushed a commit that referenced this issue Aug 22, 2022
@SurferJeffAtGoogle
test: address flaky test (#573)
1b2f872 
Not really sure why the test is flaky.  Maybe without the await
statement, the process exist before the console is written to.

Fixies #565
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@SurferJeffAtGoogle
test: address flaky test (#573)
0882612 
Not really sure why the test is flaky.  Maybe without the await
statement, the process exist before the console is written to.

Fixies #565
chingor13 pushed a commit that referenced this issue Aug 22, 2022
@SurferJeffAtGoogle
test: address flaky test (#573)
d9c53f2 
Not really sure why the test is flaky.  Maybe without the await
statement, the process exist before the console is written to.

Fixies #565
@sofisl sofisl mentioned this issue Sep 15, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Sep 15, 2022
@release-please
chore(main): release 3.1.0 (#573)
a556f75 
🤖 I have created a release *beep* *boop*
---


## [3.1.0](googleapis/nodejs-redis@v3.0.0...v3.1.0) (2022-06-30)


### Features

* support regapic LRO ([#572](googleapis/nodejs-redis#572)) ([5b30a33](googleapis/nodejs-redis@5b30a33))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
sofisl pushed a commit that referenced this issue Sep 27, 2022
@bcoe
fix(deps): google-gax v2.17.0 with mTLS (#573)
92d6718
sofisl pushed a commit that referenced this issue Sep 27, 2022
@release-please
chore: release 3.3.5 (#574)
f97ea12 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.3.5](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.4...v3.3.5) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#573](https://www.github.com/googleapis/nodejs-video-intelligence/issues/573)) ([afb19b5](https://www.github.com/googleapis/nodejs-video-intelligence/commit/afb19b5d54518d672e761881110c69e78276f80c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@sofisl sofisl mentioned this issue Sep 27, 2022
Closed
4 tasks
@sofisl sofisl mentioned this issue Oct 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Oct 11, 2022
@gcf-owl-bot
chore: update gapic-generator-typescript to v1.3.2 (#573)
8315546 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
sofisl pushed a commit that referenced this issue Oct 13, 2022
@gcf-owl-bot @sofisl
chore: update gapic-generator-typescript to v1.3.2 (#573)
f924a3c 
Committer: @alexander-fenster
PiperOrigin-RevId: 372656503

Source-Link: googleapis/googleapis@6fa858c

Source-Link: googleapis/googleapis-gen@d7c95df
sofisl pushed a commit that referenced this issue Nov 9, 2022
@bcoe
fix(deps): google-gax v2.17.0 with mTLS (#573)
60774f1
sofisl pushed a commit that referenced this issue Nov 9, 2022
@release-please
chore: release 3.3.5 (#574)
947a16f 
🤖 I have created a release \*beep\* \*boop\*
---
### [3.3.5](https://www.github.com/googleapis/nodejs-video-intelligence/compare/v3.3.4...v3.3.5) (2021-06-30)


### Bug Fixes

* **deps:** google-gax v2.17.0 with mTLS ([#573](https://www.github.com/googleapis/nodejs-video-intelligence/issues/573)) ([afb19b5](https://www.github.com/googleapis/nodejs-video-intelligence/commit/afb19b5d54518d672e761881110c69e78276f80c))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This was referenced Nov 9, 2022
Closed
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 10, 2022
@yoshi-automation
build: use gapic-generator-typescript v1.0.7. (#573)
722e062 
This new generator will bring some changes to the generated code across all libraries, but the behavior will only change for nodejs-logging and nodejs-pubsub (those two libraries that use request batching). For other libraries, the changes should be minor (the createApiCall call is simplified) and it should be safe to merge them. Please talk to @alexander-fenster if you have any questions.

PiperOrigin-RevId: 325949033

Source-Author: Google APIs <noreply@google.com>
Source-Date: Mon Aug 10 21:11:13 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 94006b3cb8d2fb44703cf535da15608eed6bf7db
Source-Link: googleapis/googleapis@94006b3
@sofisl sofisl mentioned this issue Nov 10, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 10, 2022
@gcf-owl-bot
test(nodejs): remove 15 add 16 (#1322) (#573)
962f8c5
@sofisl sofisl mentioned this issue Nov 11, 2022
Merged
4 tasks
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
chore: disable renovate dependency dashboard (#1194) (#573)
0c904cb
sofisl pushed a commit that referenced this issue Nov 11, 2022
@SurferJeffAtGoogle
test: address flaky test (#573)
301b447 
Not really sure why the test is flaky.  Maybe without the await
statement, the process exist before the console is written to.

Fixies #565
This was referenced Nov 11, 2022
Merged
Merged
sofisl pushed a commit that referenced this issue Nov 11, 2022
@gcf-owl-bot
fix: preserve default values in x-goog-request-params header (#573)
3e3130e 
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 474338479

Source-Link: googleapis/googleapis@d5d35e0

Source-Link: googleapis/googleapis-gen@efcd3f9
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZWZjZDNmOTM5NjJhMTAzZjY4ZjAwM2UyYTFlZWNkZTZmYTIxNmEyNyJ9
@sofisl sofisl mentioned this issue Jan 10, 2023
Merged
4 tasks
sofisl pushed a commit that referenced this issue Jan 10, 2023
@yoshi-automation
build: adds UNORDERED_LIST enum (#573)
d281676 
This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/d54a068d-61f9-4f27-b46c-edc44b827fbe/targets

- [ ] To automatically regenerate this PR, check this box.
sofisl pushed a commit that referenced this issue Jan 24, 2023
@alexander-fenster
fix: remove eslint, update gax, fix generated protos, run the generat…
453dfa1 
…or (#573)

Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.
sofisl pushed a commit that referenced this issue Jan 25, 2023
@alexander-fenster
fix: remove eslint, update gax, fix generated protos, run the generat…
54f592c 
…or (#573)

Run the latest version of the generator, update google-gax, update gts, and remove direct dependencies on eslint.
@sofisl sofisl mentioned this issue Sep 13, 2023
Closed
4 tasks
sofisl pushed a commit that referenced this issue Sep 13, 2023
@parthea
chore: add api_shortname and library_type to repo metadata (#573)
64d7621
@sofisl sofisl mentioned this issue Sep 14, 2023
Merged
4 tasks
@mikolajroszak mikolajroszak mentioned this issue May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanseys ryanseys

Labels
type: question Request for information or clarification. Not an issue.
Projects
None yet
Milestone
Core Future
Development

No branches or pull requests
3 participants
@jgeewax @ryanseys @stephenplusplus