Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Readable stream for runQuery in datastore #289

Closed
silvolu opened this issue Nov 7, 2014 · 0 comments
Closed

Implement Readable stream for runQuery in datastore #289

silvolu opened this issue Nov 7, 2014 · 0 comments
Assignees
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@silvolu
Copy link
Contributor

silvolu commented Nov 7, 2014

If no callback is given to runQuery, imply a Readable stream mode, e.g.:

var q = dataset.query(/*…*/);
dataset.runQuery(q)
  .on(“data”, function (entity) { console.log('I got one entity:' + entity); })
  .on(“end”, function (entity) { console.log('This is the end, my only friend'); })

And handle providing results as long as they are available.

@silvolu silvolu added this to the 1.0.0 milestone Nov 7, 2014
@stephenplusplus stephenplusplus self-assigned this Nov 7, 2014
ryanseys added a commit that referenced this issue Nov 7, 2014
…stream

datastore: runQuery as a stream. fixes #289
@jgeewax jgeewax added the api: datastore Issues related to the Datastore API. label Feb 2, 2015
@jgeewax jgeewax modified the milestones: 1.0.0, Datastore Stable Feb 2, 2015
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
sofisl pushed a commit that referenced this issue Oct 12, 2022
sofisl pushed a commit that referenced this issue Oct 12, 2022
* Switch from Mocha to Ava

* Concurrency: 5
sofisl pushed a commit that referenced this issue Oct 13, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
sofisl pushed a commit that referenced this issue Oct 13, 2022
- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 468790263

Source-Link: googleapis/googleapis@873ab45

Source-Link: googleapis/googleapis-gen@cb6f37a
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2I2ZjM3YWVmZjJhMzQ3MmU0MGE3YmJhY2U4YzY3ZDc1ZTI0YmVlNSJ9
sofisl pushed a commit that referenced this issue Oct 13, 2022
sofisl pushed a commit that referenced this issue Nov 18, 2022
PiperOrigin-RevId: 316714521

Source-Author: Google APIs <noreply@google.com>
Source-Date: Tue Jun 16 10:55:41 2020 -0700
Source-Repo: googleapis/googleapis
Source-Sha: 714a5f10f22d932bf4365dfdd57ced2c819e0ade
Source-Link: googleapis/googleapis@714a5f1
sofisl pushed a commit that referenced this issue Jan 17, 2023
* Switch from Mocha to Ava

* Concurrency: 5
sofisl pushed a commit that referenced this issue Jan 24, 2023
* Switch from Mocha to Ava

* Concurrency: 5
sofisl pushed a commit that referenced this issue Jan 24, 2023
sofisl pushed a commit that referenced this issue Jan 25, 2023
* Switch from Mocha to Ava

* Concurrency: 5
sofisl pushed a commit that referenced this issue Jan 25, 2023
sofisl pushed a commit that referenced this issue Sep 14, 2023
* Switch from Mocha to Ava

* Concurrency: 5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

4 participants